Staffan Gimåker
gimaker

  • Joined on Jan 3, 2012
gimaker deleted branch staffan/port-allocation-failure-hint at spotify/helios
Jul 13, 2016
Jul 13, 2016
@gimaker
Jul 13, 2016
gimaker merged pull request spotify/helios#949
@gimaker
When a DG fails due to port allocation issues, hint what the problem …
1 commit with 9 additions and 1 deletion
Jul 13, 2016
gimaker commented on pull request spotify/helios#949
Jul 13, 2016
gimaker opened pull request spotify/helios#949
@gimaker
When a DG fails due to port allocation issues, hint what the problem …
1 commit with 9 additions and 1 deletion
Jul 12, 2016
gimaker commented on pull request spotify/helios#944
@gimaker

👍

gimaker deleted branch dxia/upgrade-docker-client at spotify/helios
Jun 20, 2016
Jun 20, 2016
@gimaker
Jun 20, 2016
gimaker merged pull request spotify/helios#941
@gimaker
Upgrade docker-client dep from 5.0.1 to 5.0.2
1 commit with 2 additions and 2 deletions
Jun 20, 2016
gimaker commented on pull request spotify/helios#941
@gimaker

Test failure is unrelated

Jun 16, 2016
gimaker commented on pull request spotify/helios#941
@gimaker

💯

gimaker deleted branch staffan/helios-solo-ipc-lock at spotify/helios
Jun 15, 2016
Jun 15, 2016
@gimaker
  • @gimaker 2bebdda
    Merge pull request #940 from spotify/staffan/helios-solo-ipc-lock
  • @gimaker c2289b8
    helios-solo: Allow whitelisting capabilities in helios-solo
  • 1 more commit »
Jun 15, 2016
gimaker merged pull request spotify/helios#940
@gimaker
helios-solo: Allow whitelisting capabilities in helios-solo
2 commits with 33 additions and 0 deletions
Jun 15, 2016
gimaker commented on pull request spotify/helios#940
@gimaker

Test failure in JobHistoryTest.testHobHistory() seems unrelated - it's failing on master too.

Jun 14, 2016
@gimaker
Jun 14, 2016
@gimaker
Jun 14, 2016
@gimaker
  • @gimaker 8e413ab
    helios-solo: Allow whitelisting capabilities in helios-solo
Jun 14, 2016
gimaker commented on pull request spotify/helios#940
Jun 14, 2016
gimaker commented on pull request spotify/helios#940
@gimaker

I'll see if I can add a test for this as well, or at least try it out manually.

Jun 14, 2016
gimaker opened pull request spotify/helios#940
@gimaker
helios-solo: Whitelist IPC_LOCK capability in helios-solo
1 commit with 1 addition and 0 deletions
Jun 14, 2016
Jun 6, 2016
gimaker commented on pull request spotify/helios#932
@gimaker

Yes... but is that what you want? allowHostChange() returns true if status is null, allowing a roll out to be started if there is not known status.…

Jun 6, 2016
gimaker commented on pull request spotify/helios#932
@gimaker

I think that checking only the config node is enough to avoid the race condition.

Jun 6, 2016
gimaker commented on pull request spotify/helios#932
@gimaker

I believe this will throw a NoNodeException if the nodes does not exist. You probably want to catch and act on that. The node does not exist --> st…

Jun 6, 2016
gimaker commented on pull request spotify/helios#932
@gimaker

I don't have a strong opinion.

Jun 6, 2016
gimaker commented on pull request spotify/helios#932
@gimaker

I think there's still a race condition here, e.g.: Get DG and DG status [in the context of this code] Manual rolling-update triggered [concurrentl…

Jun 6, 2016
gimaker commented on pull request spotify/helios#932
@gimaker

nitpick: maybe add a comment explaining that this will be re-run and the hosts updated on the next iteration.

Jun 6, 2016
gimaker commented on pull request spotify/helios#939
@gimaker

👍