Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

build.xml #86

Closed
ghost opened this Issue Aug 14, 2011 · 5 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Aug 14, 2011

I removed the xml decleration line <XML: as it as creating errors.

I changed the swc build to exclude 'static' files, to avoid class verify errors.

Owner

gimite commented Aug 14, 2011

Can you send a pull request?

Also, what's your build environment? I haven't seen errors with my environment (Flex 4 SDK).

@ghost

ghost commented Aug 14, 2011

When I build on mac, the <xml ... line gave me errors, I deleted.

The swc static files=false makes the swc smaller and avoid class verification errors if the same class (ex: mx. util) is used in other parts of people projects.

I am not good in git, it will take me a bit to commit those 2 lines of change.

@ghost ghost closed this Aug 14, 2011

@gimite gimite reopened this Aug 14, 2011

Owner

gimite commented Aug 14, 2011

When I build on mac, the <xml ... line gave me errors, I deleted.

I found that I should not put comment before <?xml... line. It seems I haven't tested it after I added the comment... Thanks for the report. Fixed with:
efec7ad

The swc static files=false makes the swc smaller and avoid class verification errors if the same class (ex: mx. util) is used in other parts of people projects.

I still don't understand how to make this change. You mean static-link-runtime-shared-libraries="false"? It would be nice if you send me your actual change in some format (e.g. diff or whole file after the change).

@ghost

ghost commented Aug 14, 2011

Yes, line 57
static-link-runtime-shared-libraries="true">
to false.

@ghost ghost closed this Aug 14, 2011

gimite added a commit that referenced this issue Aug 14, 2011

Owner

gimite commented Aug 14, 2011

Thanks. Fixed with ed0622a

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment