Provide `NativeEndian` default for generic `Endianity` type parameters #163

Open
fitzgen opened this Issue Dec 7, 2016 · 4 comments

Projects

None yet

2 participants

@fitzgen
Member
fitzgen commented Dec 7, 2016

Almost all of our code is generic over an Endian type parameter, with the bound where Endian: Endianity.

We should default to the NativeEndianity for these type parameters.

So this

struct Whatever<Endian>
    where Endian: Endianity
{
    ...
}

would become

struct Whatever<Endian = NativeEndianity>
    where Endian: Endianity
{
    ...
}

We could do this all in one go, or incrementally with a PR for a each module at a time. Whatever works for whoever wants to pick this up.

@Geemili
Geemili commented Dec 14, 2016

Can I take this?

@fitzgen
Member
fitzgen commented Dec 14, 2016

@Geemili sure thing! Let me know if you have any questions :)

@fitzgen fitzgen added the assigned label Dec 14, 2016
@Geemili
Geemili commented Dec 30, 2016

@fitzgen I'm sorry, but I haven't been able to make time for this. If someone else wants to take this issue, they can.

@fitzgen
Member
fitzgen commented Dec 30, 2016

No problem :)

@fitzgen fitzgen removed the assigned label Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment