Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pe module delay load imports #448

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

vthib
Copy link
Contributor

@vthib vthib commented Jul 10, 2022

This PR add support for the delay load import table: https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#delay-load-import-tables-image-only

This is mostly copied from the import table implementation, and re-uses the thunks implem from it.

I'm not certain about the naming, between "delay load" & "delay load import".

Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The names look good.

crates/examples/src/readobj/pe.rs Show resolved Hide resolved
crates/examples/src/readobj/pe.rs Show resolved Hide resolved
src/read/pe/delay_load_import.rs Outdated Show resolved Hide resolved
src/read/pe/mod.rs Outdated Show resolved Hide resolved
@vthib vthib force-pushed the add-pe-delay-load-imports branch from 4f986f2 to 05431a1 Compare July 12, 2022 21:24
@philipc philipc merged commit 8e962e1 into gimli-rs:master Jul 13, 2022
@vthib vthib deleted the add-pe-delay-load-imports branch July 13, 2022 19:19
@vthib
Copy link
Contributor Author

vthib commented Jul 13, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants