Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTML link tags to use HTML5 syntax. #1621

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

jbampton
Copy link
Contributor

@jbampton jbampton commented Nov 1, 2018

The <link> element is an empty element, it contains attributes only. In HTML5 the <link> tag has no end tag. In XHTML the <link> tag must be properly closed.

https://www.w3schools.com/tags/tag_link.asp

 The `<link>` element is an empty element, it contains attributes only. In HTML5 the `<link>` tag has no end tag. In XHTML the `<link>` tag must be properly closed.
@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #1621 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1621   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          39       39           
  Lines        1931     1931           
=======================================
  Hits         1917     1917           
  Misses         10       10           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7fe48...e57245e. Read the comment docs.

@thinkerou thinkerou self-requested a review November 1, 2018 13:48
@thinkerou thinkerou merged commit 6be9b54 into gin-gonic:master Nov 1, 2018
justinfx pushed a commit to justinfx/gin that referenced this pull request Nov 3, 2018
The `<link>` element is an empty element, it contains attributes only. In HTML5 the `<link>` tag has no end tag. In XHTML the `<link>` tag must be properly closed.
@jbampton jbampton deleted the patch-2 branch November 4, 2018 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants