Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some variables #2393

Merged
merged 1 commit into from May 25, 2020
Merged

Rename some variables #2393

merged 1 commit into from May 25, 2020

Conversation

bestgopher
Copy link
Contributor

json -> jsonData, avoid conflicts with json package names
onlyfilesFS -> onlyFilesFS, little camel-case

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #2393 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2393   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          41       41           
  Lines        2348     2348           
=======================================
  Hits         2316     2316           
  Misses         18       18           
  Partials       14       14           
Impacted Files Coverage Δ
errors.go 100.00% <100.00%> (ø)
fs.go 100.00% <100.00%> (ø)
routergroup.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f261fa...f069bc8. Read the comment docs.

@thinkerou thinkerou self-requested a review May 25, 2020 10:03
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@appleboy appleboy added this to the 1.7 milestone May 25, 2020
@appleboy appleboy merged commit c9b8535 into gin-gonic:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants