Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update content-disposition header to MIME-style #2512

Merged
merged 1 commit into from Sep 25, 2020

Conversation

@eudore
Copy link
Contributor

@eudore eudore commented Sep 24, 2020

Content-Disposition in the Context.FileAttachment method is not a MIME style, but a slight performance response that can be avoided.

benchmark test file: https://github.com/eudore/eudore/blob/master/_example/textprotoHeader_test.go

@codecov
Copy link

@codecov codecov bot commented Sep 24, 2020

Codecov Report

Merging #2512 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2512      +/-   ##
==========================================
- Coverage   98.73%   98.45%   -0.28%     
==========================================
  Files          41       41              
  Lines        2367     1948     -419     
==========================================
- Hits         2337     1918     -419     
  Misses         17       17              
  Partials       13       13              
Impacted Files Coverage Δ
context.go 97.50% <ø> (-0.63%) ⬇️
render/json.go 85.29% <0.00%> (-2.52%) ⬇️
response_writer.go 93.33% <0.00%> (-1.91%) ⬇️
debug.go 92.50% <0.00%> (-1.50%) ⬇️
utils.go 96.72% <0.00%> (-0.65%) ⬇️
recovery.go 97.14% <0.00%> (-0.36%) ⬇️
gin.go 99.00% <0.00%> (-0.15%) ⬇️
fs.go 100.00% <0.00%> (ø)
auth.go 100.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3100b7c...57829e5. Read the comment docs.

@thinkerou thinkerou self-requested a review Sep 25, 2020
@thinkerou thinkerou added this to the 1.7 milestone Sep 25, 2020
Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou merged commit 540b1ef into gin-gonic:master Sep 25, 2020
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants