Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate test 'assert.Equal' #2617

Merged
merged 2 commits into from Mar 27, 2021

Conversation

@Lookingfor0
Copy link
Contributor

@Lookingfor0 Lookingfor0 commented Jan 20, 2021

There are duplicate assert.Equal(t, name, c.Param("name")) lines in TestRouteParamsByName and TestRouteParamsByNameWithExtraSlash in routes_test.go, so I remove them.

@codecov
Copy link

@codecov codecov bot commented Jan 20, 2021

Codecov Report

Merging #2617 (38530b7) into master (ed6f85c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2617   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          41       41           
  Lines        1989     1989           
=======================================
  Hits         1962     1962           
  Misses         15       15           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6f85c...38530b7. Read the comment docs.

Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou added the test label Mar 27, 2021
@thinkerou thinkerou added this to the 1.7 milestone Mar 27, 2021
@appleboy appleboy merged commit a331dc6 into gin-gonic:master Mar 27, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants