Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: convert to go:build directives #2664

merged 4 commits into from Mar 27, 2021


Copy link

@thinkerou thinkerou commented Mar 27, 2021

currently, CI fails on go master branch.

as mentioned in golang/go#41184 and golang/go#44505, Go will probably migrate to a more robust build constraints directive, as explained design doc:

so, we should prepare for that:

for Go-1.17: add all //go:build directives
for Go-1.18: remove all // +build directives

@thinkerou thinkerou requested a review from appleboy Mar 27, 2021
@thinkerou thinkerou added this to the 1.7 milestone Mar 27, 2021
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #2664 (5428711) into master (1bdf86b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2664   +/-   ##
  Coverage   98.64%   98.64%           
  Files          41       41           
  Lines        1989     1989           
  Hits         1962     1962           
  Misses         15       15           
  Partials       12       12           
Impacted Files Coverage Δ
binding/binding.go 100.00% <ø> (ø)
binding/binding_nomsgpack.go 100.00% <ø> (ø)
binding/msgpack.go 100.00% <ø> (ø)
render/msgpack.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdf86b...5428711. Read the comment docs.

Copy link
Member Author

thinkerou commented Mar 27, 2021

@appleboy maybe we should review and merge the pr at first, thanks!

@appleboy appleboy merged commit ed6f85c into gin-gonic:master Mar 27, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants