Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize code and reduce code cyclomatic complexity #2737

Merged
merged 4 commits into from Jun 3, 2021

Conversation

tylitianrui
Copy link
Contributor

@tylitianrui tylitianrui commented May 25, 2021

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2737 (df4bebe) into master (97a32b1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files          41       41              
  Lines        2074     2072       -2     
==========================================
- Hits         2047     2045       -2     
  Misses         15       15              
  Partials       12       12              
Impacted Files Coverage Δ
binding/form.go 100.00% <100.00%> (ø)
debug.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a32b1...df4bebe. Read the comment docs.

Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou added this to the v1.8 milestone Jun 3, 2021
@thinkerou thinkerou merged commit 34ce210 into gin-gonic:master Jun 3, 2021
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants