Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide custom options of TrustedPlatform for another CDN services #2906

Merged
merged 3 commits into from Oct 24, 2021

Conversation

Bisstocuz
Copy link
Contributor

  1. Make Engine.TrustedPlatform can be customized.
  2. Added some related unit tests.
  3. Added some documents about TrustedPlatform for TrustedProxies feature.

@Bisstocuz Bisstocuz changed the title [Enhancement] Provide custom options of TrustedPlatform for another CDN services Provide custom options of TrustedPlatform for another CDN services Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2906 (45a1753) into master (464535f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2906      +/-   ##
==========================================
- Coverage   98.72%   98.72%   -0.01%     
==========================================
  Files          41       41              
  Lines        3066     3062       -4     
==========================================
- Hits         3027     3023       -4     
  Misses         27       27              
  Partials       12       12              
Flag Coverage Δ
go-1.13 98.72% <100.00%> (-0.01%) ⬇️
go-1.14 98.56% <100.00%> (-0.01%) ⬇️
go-1.15 98.56% <100.00%> (-0.01%) ⬇️
go-1.16 98.56% <100.00%> (-0.01%) ⬇️
go-1.17 98.46% <100.00%> (-0.01%) ⬇️
macos-latest 98.72% <100.00%> (+0.17%) ⬆️
nomsgpack 98.70% <100.00%> (-0.01%) ⬇️
ubuntu-latest 98.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gin.go 99.10% <ø> (ø)
context.go 97.80% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464535f...45a1753. Read the comment docs.

@appleboy appleboy added this to the v1.7.5 milestone Oct 20, 2021
appleboy
appleboy previously approved these changes Oct 20, 2021
Copy link
Member

@appleboy appleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@appleboy appleboy requested a review from thinkerou Oct 20, 2021
@Bisstocuz
Copy link
Contributor Author

Bisstocuz commented Oct 23, 2021

@thinkerou code review plz

Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou merged commit 2d3d6d2 into gin-gonic:master Oct 24, 2021
23 of 24 checks passed
@Bisstocuz Bisstocuz deleted the refine-TrustedPlatform branch Oct 25, 2021
thinkerou pushed a commit that referenced this pull request Nov 20, 2021
…2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement
Bisstocuz added a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
…in-gonic#2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement

(cherry picked from commit 2d3d6d2)
Bisstocuz added a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
…in-gonic#2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement

(cherry picked from commit 2d3d6d2)
Bisstocuz added a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
…in-gonic#2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement

(cherry picked from commit 2d3d6d2)
Bisstocuz added a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
…in-gonic#2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement

(cherry picked from commit 2d3d6d2)
thinkerou pushed a commit that referenced this pull request Nov 23, 2021
…2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement
Bisstocuz added a commit to Bisstocuz/gin that referenced this pull request Nov 23, 2021
…in-gonic#2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement

(cherry picked from commit 2d3d6d2)
thinkerou pushed a commit that referenced this pull request Nov 24, 2021
…2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement
thinkerou pushed a commit that referenced this pull request Nov 24, 2021
…2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement
daheige pushed a commit to daheige/gin that referenced this pull request Apr 18, 2022
…in-gonic#2906)

* refine TrustedPlatform and docs

* refactor for switch

* refactor switch to if statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants