RawPath and Unescape URL parameters #777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 93.12% (diff: 75.00%)@@ develop #777 diff @@
==========================================
Files 16 16
Lines 1305 1310 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1217 1220 +3
- Misses 76 77 +1
- Partials 12 13 +1
|
|
Any hopes to get it merged? |
appleboy
requested changes
Feb 13, 2017
| @@ -276,14 +279,17 @@ func (engine *Engine) ServeHTTP(w http.ResponseWriter, req *http.Request) { | |||
| func (engine *Engine) handleHTTPRequest(context *Context) { | |||
| httpMethod := context.Request.Method | |||
| path := context.Request.URL.Path | |||
| if engine.UseRawPath && len(context.Request.URL.RawPath) > 0 { | |||
| path = context.Request.URL.RawPath | |||
| } | |||
There was a problem hiding this comment.
@gcnathan Could you write testing to improve code coverage? Thanks.
|
@gcnathan Any updates on this? |
|
@appleboy I'll check on how to do it. To be honest, it's quite the first time I'm playing with code coverage, so I'll check :) |
|
closed via #810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This patch aims to fix issue #722 and PR #640 .
I'm currently developing an API with URL parameters with, for example :
GET /user/:username
By assuming that username can contains special encoded parameters :
The first one is not decoded by using c.Params("username").
The second one, using '/' is currently not working at all.
Using the '*' character does not fix the issue as I've got sub routes :
GET /user/:username/infos
Feel free to comment. It aims to be a not-breaking change.