From 70597b0af1a259adba68e992657372c57bb5d6f1 Mon Sep 17 00:00:00 2001
From: Alpar Szotyori <alpar@gini.net>
Date: Wed, 22 Sep 2021 16:35:47 +0200
Subject: [PATCH 1/2] Fix button background color customization on photo tips
 and no results screens

Using a custom button style with `backgroundTint` to set the button
background color according to the material components documentation:
https://github.com/material-components/material-components-android/blob/master/docs/components/Button.md#container-attributes-2
---
 .../layout-sw600dp-land/gc_activity_photo_tips.xml   |  6 ++----
 .../gc_activity_photo_tips_with_multipage.xml        |  6 ++----
 .../layout-sw600dp-land/gc_fragment_noresults.xml    |  6 ++----
 .../res/layout-sw600dp/gc_activity_photo_tips.xml    |  5 ++---
 .../gc_activity_photo_tips_with_multipage.xml        |  5 ++---
 .../res/layout-sw600dp/gc_fragment_noresults.xml     |  5 ++---
 .../src/main/res/layout/gc_activity_photo_tips.xml   |  6 ++----
 .../layout/gc_activity_photo_tips_with_multipage.xml |  6 ++----
 .../src/main/res/layout/gc_fragment_noresults.xml    |  6 ++----
 ginicapture/src/main/res/values/styles.xml           | 12 ++++++++++++
 10 files changed, 30 insertions(+), 33 deletions(-)

diff --git a/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips.xml b/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips.xml
index 8009d2f1..ab8b7672 100644
--- a/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips.xml
+++ b/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips.xml
@@ -171,15 +171,13 @@
 
     <Button
         android:id="@+id/gc_button_photo_tips_camera"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/gc_photo_tips_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_centerHorizontal="true"
         android:layout_margin="@dimen/gc_photo_tips_bottom_button_margin"
-        android:background="@color/gc_accent"
         android:text="@string/gc_photo_tips_camera_button"
-        android:width="@dimen/gc_photo_tips_bottom_button_max_width"
-        android:textColor="@color/gc_photo_tips_button_text" />
-
+        android:width="@dimen/gc_photo_tips_bottom_button_max_width"/>
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips_with_multipage.xml b/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips_with_multipage.xml
index be9cdcb2..f1a4fb0f 100644
--- a/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips_with_multipage.xml
+++ b/ginicapture/src/main/res/layout-sw600dp-land/gc_activity_photo_tips_with_multipage.xml
@@ -203,15 +203,13 @@
 
     <Button
         android:id="@+id/gc_button_photo_tips_camera"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/gc_photo_tips_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_centerHorizontal="true"
         android:layout_margin="@dimen/gc_photo_tips_bottom_button_margin"
-        android:background="@color/gc_accent"
         android:text="@string/gc_photo_tips_camera_button"
-        android:width="@dimen/gc_photo_tips_bottom_button_max_width"
-        android:textColor="@color/gc_photo_tips_button_text" />
-
+        android:width="@dimen/gc_photo_tips_bottom_button_max_width" />
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout-sw600dp-land/gc_fragment_noresults.xml b/ginicapture/src/main/res/layout-sw600dp-land/gc_fragment_noresults.xml
index 04bbdeff..63a402be 100644
--- a/ginicapture/src/main/res/layout-sw600dp-land/gc_fragment_noresults.xml
+++ b/ginicapture/src/main/res/layout-sw600dp-land/gc_fragment_noresults.xml
@@ -191,15 +191,13 @@
 
     <Button
         android:id="@+id/gc_button_no_results_back"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/gc_noresults_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_centerHorizontal="true"
         android:layout_margin="@dimen/gc_noresults_bottom_button_margin"
-        android:background="@color/gc_noresults_button"
         android:text="@string/gc_noresults_back_button"
-        android:width="@dimen/gc_noresults_bottom_button_max_width"
-        android:textColor="@color/gc_noresults_button_text" />
-
+        android:width="@dimen/gc_noresults_bottom_button_max_width" />
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips.xml b/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips.xml
index b3df9d41..dfca5545 100644
--- a/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips.xml
+++ b/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips.xml
@@ -146,14 +146,13 @@
 
     <Button
         android:id="@+id/gc_button_photo_tips_camera"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/gc_photo_tips_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_centerHorizontal="true"
         android:layout_margin="@dimen/gc_photo_tips_bottom_button_margin"
-        android:background="@color/gc_accent"
         android:text="@string/gc_photo_tips_camera_button"
-        android:width="@dimen/gc_photo_tips_bottom_button_max_width"
-        android:textColor="@color/gc_photo_tips_button_text" />
+        android:width="@dimen/gc_photo_tips_bottom_button_max_width"/>
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips_with_multipage.xml b/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips_with_multipage.xml
index 951e7fce..d6cd2d98 100644
--- a/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips_with_multipage.xml
+++ b/ginicapture/src/main/res/layout-sw600dp/gc_activity_photo_tips_with_multipage.xml
@@ -173,14 +173,13 @@
 
     <Button
         android:id="@+id/gc_button_photo_tips_camera"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/gc_photo_tips_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_centerHorizontal="true"
         android:layout_margin="@dimen/gc_photo_tips_bottom_button_margin"
-        android:background="@color/gc_accent"
         android:text="@string/gc_photo_tips_camera_button"
-        android:width="@dimen/gc_photo_tips_bottom_button_max_width"
-        android:textColor="@color/gc_photo_tips_button_text" />
+        android:width="@dimen/gc_photo_tips_bottom_button_max_width" />
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout-sw600dp/gc_fragment_noresults.xml b/ginicapture/src/main/res/layout-sw600dp/gc_fragment_noresults.xml
index 077ad8f8..0a413421 100644
--- a/ginicapture/src/main/res/layout-sw600dp/gc_fragment_noresults.xml
+++ b/ginicapture/src/main/res/layout-sw600dp/gc_fragment_noresults.xml
@@ -165,15 +165,14 @@
 
     <Button
         android:id="@+id/gc_button_no_results_back"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/gc_noresults_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_centerHorizontal="true"
         android:layout_margin="@dimen/gc_noresults_bottom_button_margin"
-        android:background="@color/gc_noresults_button"
         android:text="@string/gc_noresults_back_button"
-        android:width="@dimen/gc_noresults_bottom_button_max_width"
-        android:textColor="@color/gc_noresults_button_text" />
+        android:width="@dimen/gc_noresults_bottom_button_max_width" />
 
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout/gc_activity_photo_tips.xml b/ginicapture/src/main/res/layout/gc_activity_photo_tips.xml
index dfa61a23..a383963c 100644
--- a/ginicapture/src/main/res/layout/gc_activity_photo_tips.xml
+++ b/ginicapture/src/main/res/layout/gc_activity_photo_tips.xml
@@ -146,13 +146,11 @@
 
     <Button
         android:id="@+id/gc_button_photo_tips_camera"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="match_parent"
         android:layout_height="@dimen/gc_photo_tips_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_margin="@dimen/gc_photo_tips_bottom_button_margin"
-        android:background="@color/gc_photo_tips_button"
-        android:text="@string/gc_photo_tips_camera_button"
-        android:textColor="@color/gc_photo_tips_button_text" />
-
+        android:text="@string/gc_photo_tips_camera_button" />
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout/gc_activity_photo_tips_with_multipage.xml b/ginicapture/src/main/res/layout/gc_activity_photo_tips_with_multipage.xml
index f7e06826..16619e39 100644
--- a/ginicapture/src/main/res/layout/gc_activity_photo_tips_with_multipage.xml
+++ b/ginicapture/src/main/res/layout/gc_activity_photo_tips_with_multipage.xml
@@ -173,13 +173,11 @@
 
     <Button
         android:id="@+id/gc_button_photo_tips_camera"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="match_parent"
         android:layout_height="@dimen/gc_photo_tips_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_margin="@dimen/gc_photo_tips_bottom_button_margin"
-        android:background="@color/gc_photo_tips_button"
-        android:text="@string/gc_photo_tips_camera_button"
-        android:textColor="@color/gc_photo_tips_button_text" />
-
+        android:text="@string/gc_photo_tips_camera_button"/>
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/layout/gc_fragment_noresults.xml b/ginicapture/src/main/res/layout/gc_fragment_noresults.xml
index d15a9e15..6a1b6164 100644
--- a/ginicapture/src/main/res/layout/gc_fragment_noresults.xml
+++ b/ginicapture/src/main/res/layout/gc_fragment_noresults.xml
@@ -165,13 +165,11 @@
 
     <Button
         android:id="@+id/gc_button_no_results_back"
+        style="@style/GiniCaptureTheme.Button"
         android:layout_width="match_parent"
         android:layout_height="@dimen/gc_noresults_bottom_button_height"
         android:layout_alignParentBottom="true"
         android:layout_margin="@dimen/gc_noresults_bottom_button_margin"
-        android:background="@color/gc_noresults_button"
-        android:text="@string/gc_noresults_back_button"
-        android:textColor="@color/gc_noresults_button_text" />
-
+        android:text="@string/gc_noresults_back_button" />
 
 </RelativeLayout>
\ No newline at end of file
diff --git a/ginicapture/src/main/res/values/styles.xml b/ginicapture/src/main/res/values/styles.xml
index 836c98e1..7880c79a 100644
--- a/ginicapture/src/main/res/values/styles.xml
+++ b/ginicapture/src/main/res/values/styles.xml
@@ -321,5 +321,17 @@
 
     <style name="GiniCaptureTheme.Review.MultiPage.PageIndicator.TextStyle" parent="Root.GiniCaptureTheme.Review.MultiPage.PageIndicator.TextStyle" />
 
+    <!-- Root widget styles -->
+
+    <style name="Root.GiniCaptureTheme.Button" parent="Widget.MaterialComponents.Button">
+        <item name="android:textColor">@color/gc_photo_tips_button_text</item>
+        <item name="backgroundTint">@color/gc_photo_tips_button</item>
+        <item name="android:insetTop">0dp</item>
+        <item name="android:insetBottom">0dp</item>
+    </style>
+
+    <!-- Widget styles used in the layouts which are overridable for customization -->
+
+    <style name="GiniCaptureTheme.Button" parent="Root.GiniCaptureTheme.Button" />
 
 </resources>

From 2d55f64793626f60e97b4e80aea4bf121b1ab320 Mon Sep 17 00:00:00 2001
From: Alpar Szotyori <alpar@gini.net>
Date: Wed, 22 Sep 2021 17:24:45 +0200
Subject: [PATCH 2/2] Bump version to 1.4.1

---
 ginicapture/src/doc/source/getting-started.rst | 2 +-
 ginicapture/src/doc/source/integration.rst     | 2 +-
 gradle.properties                              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ginicapture/src/doc/source/getting-started.rst b/ginicapture/src/doc/source/getting-started.rst
index 9d8f861f..d17b2acc 100644
--- a/ginicapture/src/doc/source/getting-started.rst
+++ b/ginicapture/src/doc/source/getting-started.rst
@@ -38,7 +38,7 @@ Now you can add the Gini Capture SDK to your app's dependencies:
 .. code:: groovy
 
     dependencies {
-        implementation 'net.gini:gini-capture-sdk:1.4.0'
+        implementation 'net.gini:gini-capture-sdk:1.4.1'
     }
 
 After syncing Gradle you can start integrating the Gini Capture SDK.
\ No newline at end of file
diff --git a/ginicapture/src/doc/source/integration.rst b/ginicapture/src/doc/source/integration.rst
index c966f9fe..22b55da2 100644
--- a/ginicapture/src/doc/source/integration.rst
+++ b/ginicapture/src/doc/source/integration.rst
@@ -120,7 +120,7 @@ To use it add the ``gini-capture-network-lib`` dependency to your app's ``build.
 
     dependencies {
         ...
-        implementation 'net.gini:gini-capture-network-lib:1.4.0'
+        implementation 'net.gini:gini-capture-network-lib:1.4.1'
     }
 
 For the Gini Capture SDK to be aware of the default implementations create the instances and pass
diff --git a/gradle.properties b/gradle.properties
index cf6ea7ed..bf82cb19 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -22,7 +22,7 @@ org.gradle.jvmargs=-Xmx2048m -XX:MaxPermSize=512m
 # mavenReleasesRepoUrl=https://repo.i.gini.net/nexus/content/repositories/releases
 # mavenOpenRepoUrl=https://repo.i.gini.net/nexus/content/repositories/open
 groupId=net.gini
-version=1.4.0
+version=1.4.1
 
 android.useAndroidX=true
 android.enableJetifier=true