Skip to content

Fiches salarié : Prendre en compte les suspensions dans la détection des notifications ratées #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rsebille merged 2 commits into from
May 6, 2024
Merged

Fiches salarié : Prendre en compte les suspensions dans la détection des notifications ratées #3872

rsebille merged 2 commits into from
May 6, 2024

Conversation

@rsebille
Copy link
Contributor

@rsebille rsebille commented Apr 4, 2024

Pourquoi ?

Simplification et amélioration suite à #3821.

J'ai ajouté la limite car il y a un peu de backlog :

* Checking missing employee records notifications:
 - found 16376 missing notification(s)
 - done!

À vérifier

  • Ajouter l'étiquette « no-changelog » ?
  • Mettre à jour le CHANGELOG_breaking_changes.md ?

@rsebille rsebille requested a review from xavfernandez April 4, 2024 02:00
@rsebille rsebille self-assigned this Apr 4, 2024
@rsebille rsebille mentioned this pull request Apr 4, 2024
Merged
2 tasks
xavfernandez
xavfernandez approved these changes Apr 4, 2024
View reviewed changes
@rsebille rsebille force-pushed the rsebille/sanitize-employee-records-missed-notifications-simplification branch from d12aeb0 to b8dd05b Compare April 5, 2024 11:17
@xavfernandez xavfernandez mentioned this pull request Apr 5, 2024
Merged
2 tasks
@rsebille rsebille force-pushed the rsebille/sanitize-employee-records-missed-notifications-simplification branch from b8dd05b to 3751d59 Compare May 2, 2024 08:30
@rsebille rsebille added the modifié Modifié dans le changelog. label May 2, 2024
rsebille added 2 commits May 2, 2024 17:15
@rsebille
employee_record: Improve missed notifications detection
eeec673 
Since 1c4c323 we can use `Approval.updated_at` to get the last time
the approval has changed, this will cover prolongations and suspensions.
It's possible we create false positive notifications but in almost all
cases an approval modification is on its start or end date.
@rsebille
employee_record: Limit how much missed notifications we create each run
0bf6557
@rsebille rsebille force-pushed the rsebille/sanitize-employee-records-missed-notifications-simplification branch from 3751d59 to 0bf6557 Compare May 2, 2024 15:15
@rsebille rsebille added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit f687a79 May 6, 2024
@rsebille rsebille deleted the rsebille/sanitize-employee-records-missed-notifications-simplification branch May 6, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees

@rsebille rsebille

Labels

modifié Modifié dans le changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsebille @xavfernandez