-
Notifications
You must be signed in to change notification settings - Fork 26
Profil utilisateur : Rendre les champs prénom et nom obligatoires [GEN-229] #3977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26680a4 to
610626e
Compare
Be consistent with the signup form, and expectations from France Travail and the ASP.
610626e to
68d8a00
Compare
|
|
||
| self.fields["title"].required = True | ||
| self.fields["birthdate"].required = True | ||
| for required_fieldname in ["title", "birthdate", "first_name", "last_name"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peut-être en faire une constante au même niveau que PROFILE_FIELDS ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J’ai vu que c’était fait ailleurs. Ne voyant pas trop l’intérêt, je ne l’ai pas fait. Ça ajoute une indirection pour peu de valeur ajoutée, expose la constante à des mutations futures. Mais l’opposition n’est pas véhémente, si tu trouves ça mieux, je change sans discuter plus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non c'est plus par cohérence et pour la lisibilité. Mais en l'état pour moi c'est tout bon (c'est approved)
xavfernandez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A voir avec le métier mais cela aurait peut-être du sens de rajouter first_name & last_name ici également:
les-emplois/itou/www/dashboard/views.py
Lines 185 to 187 in 5ee2233
| # Force the job seeker to fill its title to use the site | |
| if not request.user.title: | |
| return HttpResponseRedirect(reverse("dashboard:edit_user_info")) |
Proposé sur https://itou-inclusion.slack.com/archives/C01AQKD7MAN/p1714381080261479 |
🤔 Pourquoi ?
Nos partenaires et le site s’attendent à ce que les deux champs soient remplis.
🏝️ Comment tester