Formatage d'adresse : Gérer le cas où la BAN ne connaît pas le code postal de la commune (ie. Saint-Martin) #4020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
approved these changes
May 2, 2024
| result["insee_code"] = address.get("insee_code") | ||
| result["post_code"] = address.get("post_code") | ||
| result["city"] = address.get("city") | ||
|
|
Contributor
There was a problem hiding this comment.
Je trouve que cette fonction format_address porte assez mal son nom 😬
Je pensais qu'elle faisait juste du formatting et le fait de rajouter un appel à la DB me gênait pas mal mais en fait elle fait déjà également un appel à l'API de geocoding.
Peut-être compute_hexa_address ?
Contributor
Author
There was a problem hiding this comment.
C'est même pas spécifique au format HEXA, juste qu'on l'utilise pour "nettoyer" ce qui est renseigné dans les emplois pour préremplir au mieux les champs HEXA.
Mais oui le nommage est pas fou, je me le note pour plus tard :).
xavfernandez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
La BAN ne semble pas connaître le code postal de Saint-Martin ce qui crée une erreur lors de la géolocalisation de l'adresse dans les fiches salariés : LES-EMPLOIS-PROD-1R0
🍰 Comment ?
Si la BAN ne nous retourne pas de code postal alors nous allons chercher celui présent dans le référentiel INSEE (
cities.City).🏝️ Comment tester