Notifications : Réessayer d’envoyer les emails lorsque Mailjet indique un problème #4115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
xavfernandez
approved these changes
May 22, 2024
francoisfreitag
force-pushed
the
ff/resend-email
branch
from
ff0c93a to
eee51cd
Compare
Before this commit, emails that couldn’t be sent were simply discarded, because the code didn’t check the status from anymail. Anymail exposes a status for each recipient of an email, raising many questions on the expected behavior should one fail to be delivered out of multiple recipients. As a first step, simply trust Mailjet API Status field. https://anymail.dev/en/stable/sending/django_email/#refused-recipients https://anymail.dev/en/stable/sending/anymail_additions/#anymail.message.AnymailStatus
francoisfreitag
force-pushed
the
ff/resend-email
branch
from
eee51cd to
3fdb785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Éviter de perdre des emails, ce qui peut-être très gênant pour les utilisateurs.
🍰 Comment ?
https://anymail.dev/en/stable/sending/django_email/#refused-recipients
https://anymail.dev/en/stable/sending/anymail_additions/#anymail.message.AnymailStatus