API: Correction d'un serializer de l'api SIAE #4123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
force-pushed
the
alaurent/api
branch
2 times, most recently
from
bf1b6a9 to
4c059df
Compare
francoisfreitag
approved these changes
May 23, 2024
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Peut-être avec un test de non régression ?
tonial
force-pushed
the
alaurent/api
branch
2 times, most recently
from
870287f to
1cbee0a
Compare
Contributor
Author
|
C'est fait ! |
tonial
force-pushed
the
alaurent/api
branch
2 times, most recently
from
7f5d6fe to
e68795c
Compare
|
|
||
| def _fix_contract_type_enum(apps, schema_editor): | ||
| JobDescription = apps.get_model("companies", "JobDescription") | ||
| JobDescription.objects.filter(contract_type="FED_TERM_I_PHC").update(contract_type="FIXED_TERM_I_PHC") |
Contributor
There was a problem hiding this comment.
Il faudrait voir avec le pilotage qui récupère cette donnée:
les-emplois/itou/metabase/tables/job_descriptions.py
Lines 32 to 37 in f332e1d
Quitte à leur mettre une rustine temporaire pour leur re-transformer FIXED_TERM_I_PHC en FED_TERM_I_PHC.
Because ContractType FIXED_TERM_I_PHC is stored as FED_TERM_I_PHC in the database.... Next commit will fix the value in the enum + database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Parce que
ContractType.FIXED_TERM_I_PHCa pour valeurFED_TERM_I_PHCdans la base de données.Peut-être devrait-on changer cette valeur en db avec une migration en plus de cette amélioration du code ?
cf sentry : https://itou.sentry.io/issues/5132982995/?project=6164438&query=is%3Aunresolved+level%3Aerror&referrer=issue-stream&statsPeriod=14d&stream_index=8
🍰 Comment ?
💻 Captures d'écran
🚨 À vérifier
🏝️ Comment tester