Statistiques: Nombre de candidats qui prennent le contrôle de leur compte [GEN-1642] #4149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celine-m-s
reviewed
May 30, 2024
celine-m-s
reviewed
May 30, 2024
|
|
||
| count = 0 | ||
| start = time.perf_counter() | ||
| while batch_users := users[:10000]: |
Contributor
There was a problem hiding this comment.
J'ai un peu de mal à comprendre cette boucle. Je ne vois pas la condition de sortie. Pour moi, on ne prend en compte que les 10000 premiers résultats et on boucle à l'infini.
Contributor
Author
There was a problem hiding this comment.
ça évalue la qs à chaque passage, et récupère donc à chaque fois des nouveaux utilisateurs
celine-m-s
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour ajouter une métrique d'impact
🍰 Comment ?
Ajout du champ
User.first_loginPour les utilisateurs qui ont déjà pris le contrôle de leur compte la valeur est artificiellement remplie à
user.date_joined💻 Captures d'écran
🚨 À vérifier
🏝️ Comment tester