Skip to content

Statistiques: Correction d'un code de dénormalisation#4171

Merged
tonial merged 1 commit intomasterfrom
alaurent/try_fixing_signal
Jun 5, 2024
Merged

Statistiques: Correction d'un code de dénormalisation#4171
tonial merged 1 commit intomasterfrom
alaurent/try_fixing_signal

Conversation

@tonial
Copy link
Contributor

@tonial tonial commented Jun 4, 2024

🤔 Pourquoi ?

Pour corriger le test flaky dans la CI et probablement un trou dans la raquette en prod.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

💻 Captures d'écran

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

@tonial tonial added the modifié Modifié dans le changelog. label Jun 4, 2024
@tonial tonial requested a review from rsebille June 4, 2024 13:20
@tonial tonial self-assigned this Jun 4, 2024
@tonial tonial force-pushed the alaurent/try_fixing_signal branch 2 times, most recently from 5a8654c to 80b6352 Compare June 4, 2024 13:34
@tonial tonial requested a review from xavfernandez June 4, 2024 13:35
Copy link
Contributor

@rsebille rsebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour la science 😁.

@tonial tonial added this pull request to the merge queue Jun 5, 2024
@tonial tonial removed this pull request from the merge queue due to a manual request Jun 5, 2024
@tonial tonial force-pushed the alaurent/try_fixing_signal branch 2 times, most recently from cdc1701 to b19d388 Compare June 5, 2024 04:28
@tonial tonial enabled auto-merge June 5, 2024 04:29
…ignal

Django stores signal handlers as weak references by default. Thus, if
your receiver is a local function, it may be garbage collected. To
prevent this, pass weak=False when you call the signal’s connect()
method.
@tonial tonial force-pushed the alaurent/try_fixing_signal branch from b19d388 to 3330799 Compare June 5, 2024 04:40
@tonial tonial added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit 292bcb1 Jun 5, 2024
@tonial tonial deleted the alaurent/try_fixing_signal branch June 5, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants