Conversation
We don't want to fine tune `CONVENTION_DEACTIVATION_THRESHOLD` each years, especially as we are at the end of the line and that number is dependant of possible changes in ASP or DDETS's processes.
dejafait
approved these changes
Jun 18, 2024
Contributor
dejafait
left a comment
There was a problem hiding this comment.
Excellente solution !
LVGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le nombre de SIAE à déconventionner est quasiment le même depuis plusieurs semaines/mois, mais cette année nous dépassons encore le seuil enregistré (beaucoup d'antennes requalifié ou de nouvelle structures pour l'intégration de la DNS dans l'Extranet ASP) et gardons donc conventionné des structures qui n'ont plus lieu de l'être.