UX/UI : Simplifier la création des filtres de départements pour la recherche employeur / postes #4272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
force-pushed
the
ff/dpt
branch
2 times, most recently
from
0aed187 to
5514628
Compare
Member
Author
|
Arf, il y a toujours un problème avec le rechargement des départements si l’utilisateur change de ville. Je corrige. |
The departments were computed by iterating over the list of objects, forcing to fetch them all to memory. For Paris, with 100 kms radius, that’s almost 2.5K job offers. That’s a lot of work, where a basic adjacency list is likely sufficient for users. Also, the departments field had to be reloaded when the search distance changed. That would lead to a pretty annoying UI with the upcoming changes to [Dropdown filters](https://zeroheight.com/85c89893b/p/207551-buttons): when a department is selected, the department field is reloaded (with HTMX), closing the dropdown filter. Hence, a user wanting to select multiple departments need to open the dropdown, click a department. The results load, they can then open the dropdown, click a department, and so on. Instead, use an adjacency list. Users can of course ask for an impossible combination of filters, such as SIAE 5 kms from Limoges and in Corrèze. They’ll just get no results, and pick more sensible filters. The assertNumQueries were outdated, and were updated to better reflect the actual queries.
tonial
approved these changes
Jun 21, 2024
Contributor
tonial
left a comment
tonial
left a comment
There was a problem hiding this comment.
Ça semble en effet bien plus simple de pré-stocker les départements limitrophes :)
Par contre, je n'ai pas du tout vérifié DEPARTMENTS_ADJACENCY, on va faire confiance à la page github 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?