UX/UI : Correction d’un petit bug sur la recherche employeur #4277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellodeloo
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
1 similar comment
francoisfreitag
force-pushed
the
ff/filter-company
branch
2 times, most recently
from
26b7580 to
e96e7e6
Compare
francoisfreitag
added
1-recette-jetable
francoisfreitag
force-pushed
the
ff/filter-company
branch
4 times, most recently
from
61053bd to
6db5078
Compare
leo-naeka
approved these changes
Jun 27, 2024
francoisfreitag
force-pushed
the
ff/filter-company
branch
from
6db5078 to
72dd2ec
Compare
leo-naeka
approved these changes
Jul 1, 2024
There’s only one possible result when the company is used. Clear the rest of the filters from the URL (except city and distance, which are used to validate the company value) to fix the following STR: 1. Set distance to 100 kms 2. Filter on a company >5 kms away from the city 3. Set distance to 5 kms There are no filters active in the UI, yet there are no results, because the company=PK parameter is present in the URL, but that choice is (now) invalid and the select2 cannot be initialized with that value.
francoisfreitag
force-pushed
the
ff/filter-company
branch
from
72dd2ec to
b54d5ee
Compare
xavfernandez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Seul un résultat est possible lorsqu’on utilise la recherche entreprise. Enlever le reste des filtres afin qu’ils n’interagissent pas avec l’entreprise des résultats:
Sur la prod : il n’y a aucun filtre actif dans l’UI, mais aucun résultat. Ceci est dû à la présence de
company=PKdans l’URL, qui est un choix maintenant invalide. Le select2 ne peut pas être initialisé avec un choix qui n’est pas dans la liste, et n’indique pas d’erreur.🏝️ Comment tester
https://c1-review-ff-filter-company.cleverapps.io/