GPS : liste des groupes > la date n'apparaît pas pour les groupes créés en masse // changement de l'ordre#4279
Merged
celine-m-s merged 4 commits intomasterfrom Jun 26, 2024
Merged
Conversation
celine-m-s
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
celine-m-s
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
celine-m-s
removed
the
1-recette-jetable
celine-m-s
force-pushed
the
celinems/gps-ui
branch
from
9780b38 to
6312259
Compare
- Show groups created lately first. - Don't display the creation date if membership was created by the initial script
celine-m-s
force-pushed
the
celinems/gps-ui
branch
from
ccf3a37 to
5075b4a
Compare
xavfernandez
approved these changes
Jun 26, 2024
| FollowUpGroup.objects.follow_beneficiary(beneficiary=beneficiary, user=other_member, is_referent=True) | ||
| assert group.memberships.count() == 2 | ||
| other_membership = group.memberships.get(member=other_member) | ||
| assert other_membership.is_referent is True # No limit to the number of referent |
Contributor
There was a problem hiding this comment.
On est d'accord que dans ce test il n'y a qu'une seule membership référente & active ?
Contributor
Author
There was a problem hiding this comment.
À la fin, oui, car l'autre membership.is_referent est passée à False ligne 52. Mais je suis d'accord avec toi, ce n'est pas évident.
Contributor
Author
There was a problem hiding this comment.
Je modifierai ce test une autre fois. Là, j'aimerais bien passer cette PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Demandes remontées pendant l'OL.
J'ai aussi mis à jour les fixtures pour répliquer l'import initial.
💻 Captures d'écran
🚨 À vérifier
🏝️ Comment tester
Se connecter avec l'ETTI (utilisatrice Daphnée Delavigne) puis, en bas du tableau de bord, cliquer sur « Visualiser les bénéficiaires ».