PASS IAE: Mise en conformité des règles de prolongations [GEN-270] #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
xavfernandez
force-pushed
the
xfernandez/prolongation_rules
branch
3 times, most recently
from
48d3509 to
9d492ac
Compare
xavfernandez
force-pushed
the
xfernandez/prolongation_rules
branch
2 times, most recently
from
29d5f9c to
1c483ce
Compare
xavfernandez
force-pushed
the
xfernandez/prolongation_rules
branch
2 times, most recently
from
b4fc872 to
4834620
Compare
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Les deux premiers commits : « faire et défaire, c’est toujours travailler ». 🙈
C’est très solide, et je m’attendais à un diff plus gros. Les petits encarts d’explication aident bien à comprendre 👍
| enums.ProlongationReason.HEALTH_CONTEXT: { | ||
| "max_duration": datetime.timedelta(days=365), | ||
| "max_cumulative_duration": datetime.timedelta(days=365), | ||
| "help_text": "NE PAS UTILISER", # This value shouldn't appear anywhere but just in case |
itou/templates/approvals/includes/prolongation_declaration_form.html
Outdated
Show resolved
Hide resolved
tonial
approved these changes
Jul 4, 2024
Contributor
tonial
left a comment
tonial
left a comment
There was a problem hiding this comment.
Rien à ajouter par rapport à la relecture de @francoisfreitag si ce n'est que le 1er commit de la PR ne me semble pas super utile, vu que tu remets une valeur d'enum sous forme de dict dans le 2nd commit, et tu remets un label dans le 3e ^^
xavfernandez
force-pushed
the
xfernandez/prolongation_rules
branch
4 times, most recently
from
2a7c948 to
bf390ea
Compare
francoisfreitag
approved these changes
Jul 4, 2024
label isn't used anywhere
Before this change you could sum the different cumulative duration ( 3 years RQTH + 5 years SENIOR for a total of 8 years): now it won't be possible to request a RQTH prolongation if there was already 3+ years of prolongation for other reason Hence, bump the max_cumulative_duration for COMPLETE_TRAINING to 10 years (since it is not supposed to have a maximum duration).
Those reasons don't have any cumulative duration limit.
- prevent the selection of unusable reason & add info - add info on max date when lower than the expected duration
xavfernandez
force-pushed
the
xfernandez/prolongation_rules
branch
from
c2207b2 to
32c484a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Empêcher de saisir certains motifs de prolongations s'il y a déjà un certain nombre de prolongations.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
Créer des PASS avec suffisamment de prolongations dans le passé et essayer de les prolonger.
J'essaierai de générer des PASS intéressant demain.
💻 Captures d'écran