GPS : indiquer que le téléphone du membre n'est pas renseigné ou que la date de naissance du bénéficiaire n'est pas renseignée #4405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celine-m-s
force-pushed
the
celinems/gps-phone
branch
from
8ffb6da to
70bcb7b
Compare
celine-m-s
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
celine-m-s
changed the title
celine-m-s
force-pushed
the
celinems/gps-phone
branch
from
f5917a1 to
25c1f32
Compare
celine-m-s
removed
the
1-recette-jetable
celine-m-s
force-pushed
the
celinems/gps-phone
branch
from
25c1f32 to
1f8ceae
Compare
xavfernandez
approved these changes
Jul 10, 2024
itou/templates/users/details.html
Outdated
| <i class="ri-file-copy-line"></i> | ||
| </button> | ||
| {% matomo_event "gps" "clic" "copied_user_pe_id" as matomo_event_attrs %} | ||
| {% include 'includes/copy_to_clipboard.html' with content=profile.pole_emploi_id css_classes="btn-link" matomo_event_attrs=matomo_event_attrs text=" " %} |
Contributor
There was a problem hiding this comment.
Je me demande si on ne devrait pas modifier l'include pour ne pas mettre de span quand text est vide (cela nécessiterait d'enlever le |default:"Copier" mais il n'est pas utilisé si souvent) ou alors rajouter un {% if not only_icon|default:False %} autour de la balise span ?
Contributor
Author
There was a problem hiding this comment.
Finalement je préfère ton idée de only_icon. Je change.
xavfernandez
approved these changes
Jul 10, 2024
celine-m-s
force-pushed
the
celinems/gps-phone
branch
from
08a32d8 to
d0c0b70
Compare
celine-m-s
force-pushed
the
celinems/gps-phone
branch
from
d0c0b70 to
80bc939
Compare
Contributor
|
Trop bien ce include 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour inciter les membres à renseigner le leur. J'en ai profité pour ajouter un bouton pour copier l'e-mail rapidement.
J'ai aussi réorganisé et nettoyé le HTML et les tests.
🚨 À vérifier
🏝️ Comment tester
Consulter la page d'un bénéficiaire dans GPS qui a plusieurs membres.
💻 Captures d'écran