Page d’accueil : modale nouveautés#4446
Merged
Merged
Conversation
calummackervoy
requested review from
celine-m-s,
francoisfreitag and
xavfernandez
tonial
reviewed
Jul 22, 2024
Contributor
tonial
left a comment
tonial
left a comment
There was a problem hiding this comment.
Beau boulot
Certaines commentaires sont des suggestions ouvertes à discussion, n'hésite pas si tu veux qu'on en discute demain matin
Contributor
Author
|
@tonial merci, j'ai implementé ces changements ! Je squasherai mes commits après t'as eu l'occassion de regarder les changements :) |
tonial
reviewed
Jul 25, 2024
Contributor
tonial
left a comment
tonial
left a comment
There was a problem hiding this comment.
Il reste quelques dernières remarques et c’est bon pour moi :)
calummackervoy
force-pushed
the
calum/modale-nouveautes
branch
from
f62aa5a to
39c4fc3
Compare
xavfernandez
reviewed
Aug 1, 2024
celine-m-s
added
the
1-recette-jetable
Contributor
|
👋 |
celine-m-s
removed
the
1-recette-jetable
Contributor
|
Je supprime la recette jetable (qui n'a pas pu être créée d'ailleurs) car Clever est instable aujourd'hui. |
calummackervoy
added
1-recette-jetable
calummackervoy
force-pushed
the
calum/modale-nouveautes
branch
from
340871d to
411fc91
Compare
calummackervoy
added
1-recette-jetable
calummackervoy
force-pushed
the
calum/modale-nouveautes
branch
from
b84b6d4 to
01450dc
Compare
Contributor
Author
|
La recette jetable a été validée 🎉 c'est prêt à merger ? :) |
xavfernandez
reviewed
Aug 8, 2024
calummackervoy
force-pushed
the
calum/modale-nouveautes
branch
from
01450dc to
4107674
Compare
xavfernandez
approved these changes
Aug 12, 2024
feat(communications/admin): AnnouncementCampaign admin and validation fix(AnnouncementCampaignAdminForm): modifying date range feat(communications): render news modal on first device visit feat(communications): implemented a cache for AnnouncementCampaign greatly restricts database usage AnnouncementItemFactory: French locale and better string content refactor(CommunicationsConfig): django signals safe to import at module level refactor(communications): model changes requested in feedback refactor(communications): implemented requested cache changes fix: make quality fix(communications): AnnouncementCampaign ordering fix(static): delete unused image file feat(communications): AnnouncementItem.unique_together on campaign and priority refactor(communications): cache changes, added live field refactor(communications): UniqueConstraint on start_date refactor(communications/cache): rename variable make quality requested changes fix: tests for new constraint suggested changes
calummackervoy
force-pushed
the
calum/modale-nouveautes
branch
from
4107674 to
2caf816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Prévenons nos utilisateurs des nouveautés du mois passé. Pour cela, on affichera une modale résumant les 3 (ou moins) nouveautés les plus importantes, et un bouton qui envoie vers la page nouveauté. [Chaque mois]
🍰 Comment ?
Ajout d'un système générique à cette but qui soutien des variations entre
max_items(défaut 3) et les différentes duréeslocalStorage🚨 À vérifier
💻 Captures d'écran