Skip to content

UX/UI : Refonte des layouts [GEN-204] #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2024
Merged

UX/UI : Refonte des layouts [GEN-204] #4483

merged 2 commits into from
Aug 26, 2024

Conversation

@hellodeloo
Copy link
Contributor

@hellodeloo hellodeloo commented Jul 30, 2024 •
edited
Loading

🤔 Pourquoi ?

Pour permettre aux utilisateurs authentifiés d'avoir une interface plus "applicative" et différenciée des utilisateurs non connectés

🍰 Comment ?

  • maj du thème en > v2.0.0
  • ajout d'une classe "mère" sur le <body>
  • maj du footer et affichage conditionnel selon l'authentification de l'utilisateur
  • maj du header + navigation principale selon l'authentification de l'utilisateur

💻 Captures d'écran

@hellodeloo hellodeloo self-assigned this Jul 30, 2024
@hellodeloo hellodeloo changed the title Deloo/update UI layouts UX/UI: Refonte des layouts Jul 30, 2024
@hellodeloo hellodeloo changed the title UX/UI: Refonte des layouts UX/UI : Refonte des layouts Jul 30, 2024
@notion-workspace
Copy link

notion-workspace bot commented Jul 30, 2024

🎨 Refonte UX/UI - Le menu et layout des pages connecté

@hellodeloo hellodeloo added the ajouté Ajouté dans le changelog. label Jul 30, 2024
@hellodeloo hellodeloo marked this pull request as draft July 30, 2024 10:29
@hellodeloo hellodeloo added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Jul 30, 2024
@github-actions
Copy link

github-actions bot commented Jul 30, 2024

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@hellodeloo hellodeloo force-pushed the deloo/update-ui-layouts branch from 3232155 to 3791f9f Compare July 30, 2024 16:01
@hellodeloo hellodeloo marked this pull request as ready for review July 30, 2024 16:03
@hellodeloo hellodeloo force-pushed the deloo/update-ui-layouts branch from 6829846 to 271d934 Compare July 31, 2024 07:20
@francoisfreitag francoisfreitag self-assigned this Jul 31, 2024
@hellodeloo hellodeloo force-pushed the deloo/update-ui-layouts branch from 271d934 to 847622b Compare July 31, 2024 12:03
@hellodeloo hellodeloo marked this pull request as draft July 31, 2024 13:50
@hellodeloo hellodeloo force-pushed the deloo/update-ui-layouts branch 2 times, most recently from 07d1a2d to 55dd32c Compare August 2, 2024 09:22
francoisfreitag
francoisfreitag reviewed Aug 5, 2024
View reviewed changes
@francoisfreitag

This comment was marked as outdated.

Sign in to view
@francoisfreitag francoisfreitag force-pushed the deloo/update-ui-layouts branch from 4604190 to ed11f9a Compare August 5, 2024 15:57
@hellodeloo
Copy link
Contributor Author

hellodeloo commented Aug 6, 2024 •
edited
Loading

Petits soucis de mise en forme pour le dropdown d’aide: (texte tronqué)

Arf, j'avais pas ce pb. C'est corrigé

@francoisfreitag

This comment was marked as outdated.

Sign in to view
@francoisfreitag francoisfreitag force-pushed the deloo/update-ui-layouts branch from 5233a9f to 018ac03 Compare August 7, 2024 08:41
@francoisfreitag
Copy link
Member

francoisfreitag commented Aug 7, 2024 •
edited
Loading

C’est normal d’avoir cet espace vide chez les candidats ?
image

@hellodeloo
Copy link
Contributor Author

hellodeloo commented Aug 7, 2024

C’est normal d’avoir cet espace vide chez les candidats ?

😵‍💫 mais pas du tout non

@francoisfreitag
Copy link
Member

francoisfreitag commented Aug 7, 2024

J’ai toujours le problème du label du filtre centré dans l’offside pour la liste des candidatures d’un candidat :
image

@francoisfreitag
Copy link
Member

francoisfreitag commented Aug 7, 2024

C’est voulu de ne pas avoir mis en valeur « Organisation > Collaborateurs » sur la page d’invitation ?
image

@hellodeloo hellodeloo force-pushed the deloo/update-ui-layouts branch from 6a22664 to 954d636 Compare August 7, 2024 13:44
@francoisfreitag francoisfreitag mentioned this pull request Aug 8, 2024
Merged
@francoisfreitag francoisfreitag force-pushed the deloo/update-ui-layouts branch from d84029b to c553c05 Compare August 8, 2024 16:43
@francoisfreitag francoisfreitag changed the title UX/UI : Refonte des layouts UX/UI : Refonte des layouts [GEN-204] Aug 9, 2024
@hellodeloo hellodeloo force-pushed the deloo/update-ui-layouts branch from ff1e29a to 2d383bd Compare August 13, 2024 14:16
@francoisfreitag francoisfreitag force-pushed the deloo/update-ui-layouts branch 14 times, most recently from d35883e to c0a4a96 Compare August 20, 2024 15:45
@francoisfreitag francoisfreitag marked this pull request as ready for review August 20, 2024 15:45
@francoisfreitag
Copy link
Member

francoisfreitag commented Aug 20, 2024

Changements :

  • squash des commits
  • rebase sur master
  • utilisation de jolies apostrophes pour S’inscrire et Besoin d’aide
  • Correction des aria-label du menu de navigation secondaire (qui n’est pas que pour le mobile)
  • renommage du template tag « menu » en « nav » qui est un peu plus précis
  • Passage du menu pour les anonymes au template tag « nav » pour bénéficier du calcul du statut active au lieu de le calculer manuellement dans le template
  • Mise à jour des docs des assertNumQueries touchées

@francoisfreitag francoisfreitag force-pushed the deloo/update-ui-layouts branch 2 times, most recently from 938706c to 5f3ae5b Compare August 21, 2024 09:00
rsebille
rsebille approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@rsebille rsebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏
Je ne suis passé que sur la partie python, le HTML ayant dû être vu et revu via la recette.

itou/utils/templatetags/nav.py
self.active_view_names = active_view_names
self.matomo_event_category = matomo_event_category
self.matomo_event_name = matomo_event_name
self.matomo_event_option = matomo_event_option
Copy link
Contributor

@rsebille rsebille Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas super fan des attributs non listé dans les classes, surtout que là c'est utilisé comme API dans NavGroup()

Suggested change
self.matomo_event_option = matomo_event_option
self.matomo_event_option = matomo_event_option
self.active = None

Copy link
Member

@francoisfreitag francoisfreitag Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je l’avais listé directement au niveau de la classe. Je viens de le déplacer dans __init__ pour qu’il soit avec les autres. 🤷
https://github.com/gip-inclusion/les-emplois/pull/4483/files/5f3ae5bd2000ec4e33908bf500fb1e09af2ad1d7#diff-4ae4b0a18514f6ac8a6752236a895396b5745f7617ef7eed2087817d3810f8d7R10

hellodeloo and others added 2 commits August 26, 2024 14:52
@hellodeloo @francoisfreitag
Add quick access menu for logged in users
d4d65f4 
Use a template tag to render the menu. Allows for a declarative menu
content, and rendering each bit rather than repeating the same HTML over
and over again. Also, allows more control (and tests) over the active
state.

test_job_application_external_transfer_only_for_lone_users and
test_job_application_external_transfer_disabled_for_bad_state were
relying on `.dropdown-structure` being unique on the page. The selector
has been updated to only look for that item in the action bar.
@francoisfreitag
Prefer organization over structure for companies
ea8d85e 
Consistently use the same wording.

https://www.notion.so/plateforme-inclusion/noms-de-rubrique-diff-rents-organisation-et-structure-5c7bb2dd03d5428382868c1f26c0ba8e
@francoisfreitag francoisfreitag force-pushed the deloo/update-ui-layouts branch from d5462d9 to ea8d85e Compare August 26, 2024 12:58
@francoisfreitag francoisfreitag added this pull request to the merge queue Aug 26, 2024
Merged via the queue into master with commit d946863 Aug 26, 2024
@francoisfreitag francoisfreitag deleted the deloo/update-ui-layouts branch August 26, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francoisfreitag francoisfreitag francoisfreitag left review comments

@rsebille rsebille rsebille approved these changes

Assignees

@francoisfreitag francoisfreitag

@hellodeloo hellodeloo

Labels

1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC ajouté Ajouté dans le changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hellodeloo @francoisfreitag @rsebille