Candidat: Création d'un espace candidats [GEN-1804] #4535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
force-pushed
the
alaurent/job_seeker
branch
2 times, most recently
from
ad1d260 to
af0ee66
Compare
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
5 times, most recently
from
c549ed5 to
a71d7ba
Compare
xavfernandez
added
1-recette-jetable
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
3 times, most recently
from
e76b823 to
6acb4c0
Compare
xavfernandez
added
the
1-recette-jetable
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
2 times, most recently
from
6ab0936 to
3fe2041
Compare
xavfernandez
added
1-recette-jetable
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
4 times, most recently
from
5d5c8e2 to
71dbaae
Compare
Contributor
|
Recette dispo ici: https://c1-review-alaurent-job-seeker.cleverapps.io/ |
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
3 times, most recently
from
8e8cc1b to
2acd68a
Compare
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
12 times, most recently
from
051e49d to
d9e3b34
Compare
rsebille
approved these changes
Aug 27, 2024
Contributor
rsebille
left a comment
rsebille
left a comment
There was a problem hiding this comment.
J'ai pas trop re-regardé les templates donc on va faire confiance à la recette et aux snapshots :D.
Comment on lines
11
to
17
| {% if diagnosis.author_prescriber_organization %} | ||
| Ce diagnostic émis par un prescripteur habilité vous donnera droit en cas d’embauche, | ||
| {% else %} | ||
| Les critères que vous avez sélectionnés vous donnent droit en cas d’embauche, | ||
| {% endif %} |
Contributor
There was a problem hiding this comment.
C'est plus simple à faire mais ça se base sur des suppositions, donc si le comportement supposé change on aura un état erroné ici et rien qui nous alertera.
Et c'est toujours plus simple d'arriver sur un bout de code qui te dit explicitement ce qu'il attend plutôt que tomber sur une condition un peu large et de pas comprendre ce qu'on voulais faire originellement.
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
4 times, most recently
from
c0c989b to
50f285e
Compare
Only authorized prescribers can create diagnosis, let's make it clear.
To easily identify which page is which (between /job-seekers/details/ & /approvals/detail/)
xavfernandez
force-pushed
the
alaurent/job_seeker
branch
from
50f285e to
71cb8db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran