[GEN-1927] Demandeur d’emploi: coordonnées importées des conseillers de France Travail #4573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calummackervoy
commented
Aug 19, 2024
itou/gps/excel.py
Outdated
|
|
||
|
|
||
| @timeit | ||
| def parse_gps_import(filename="export_gps.xlsx"): |
calummackervoy
commented
Aug 19, 2024
calummackervoy
commented
Aug 19, 2024
calummackervoy
commented
Aug 19, 2024
calummackervoy
force-pushed
the
calum/gps-conseiller-emploi
branch
from
ab7ce04 to
194b428
Compare
francoisfreitag
changed the title
Contributor
Author
|
@hellodeloo j'ai mis à jour la description du PR avec quelques instructions 🙂 n'hésitez pas si j'ai raté qqc ! |
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Seul environ 10 % du fichier semble avoir été importés. Beaucoup de candidats de ce fichier sont inconnus chez nous ?
hellodeloo
reviewed
Aug 20, 2024
Contributor
hellodeloo
left a comment
hellodeloo
left a comment
There was a problem hiding this comment.
@calummackervoy j'ai fait ce commit pour corriger l'ui.
hellodeloo
reviewed
Aug 20, 2024
calummackervoy
force-pushed
the
calum/gps-conseiller-emploi
branch
from
8efccb7 to
118458b
Compare
calummackervoy
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
calummackervoy
force-pushed
the
calum/gps-conseiller-emploi
branch
from
118458b to
7b7d076
Compare
calummackervoy
commented
Aug 21, 2024
| </div> | ||
| </div> | ||
| </div> | ||
|
|
Member
There was a problem hiding this comment.
Idéalement, mieux vaut éviter les changements qui n’ont pas de rapport avec la PR en cours.
hellodeloo
force-pushed
the
calum/gps-conseiller-emploi
branch
from
3cc4143 to
58d1403
Compare
calummackervoy
force-pushed
the
calum/gps-conseiller-emploi
branch
from
58d1403 to
4dfb37e
Compare
francoisfreitag
approved these changes
Aug 22, 2024
Member
|
J’ai poussé un petit commit de simplification. Une mini suggestion de wording, et c’est tout bon 🎉 ! |
calummackervoy
force-pushed
the
calum/gps-conseiller-emploi
branch
from
1d9a41f to
b1db5a2
Compare
refactor: FranceTravailContact uses JobSeekerProfile feat(UserDetailView): display France Travail contact feat(import_advisor_information): handle NULL values on contact info make quality remove superfluous address information in test fix: some ui adjusments refactor: requested changes fix(import_advisor_information.py): progress counting on matches, not row imports refactor: requested changes feat(gps): track expand events on conseiller infos feat(gps): added matomo tracking on new feature fix: CSS classes on clipboard button Speed up the command Instead of reading continuously the Excel document, load interesting data into a dict and address content by NIR. Remove unused count_missing_users gps: importation des conseillers FT d'un fichier excel refactor: FranceTravailContact uses JobSeekerProfile feat(UserDetailView): display France Travail contact feat(import_advisor_information): handle NULL values on contact info make quality remove superfluous address information in test fix: some ui adjusments refactor: requested changes fix(import_advisor_information.py): progress counting on matches, not row imports refactor: requested changes feat(gps): track expand events on conseiller infos feat(gps): added matomo tracking on new feature fix: CSS classes on clipboard button refactor(import_advisor_information.py): remove unused code fix: typo fix: matomo event name Remove unnecessary queryset construction fix(users/details.html): aria-label text feat(import_advisor_information): parameterize import file
calummackervoy
force-pushed
the
calum/gps-conseiller-emploi
branch
from
b1db5a2 to
7771c39
Compare
calummackervoy
commented
Aug 22, 2024
Comment on lines
+31
to
+35
| parser.add_argument( | ||
| "import_excel_file", | ||
| type=str, | ||
| help="The file directory of the GPS export file, with extension .xlsx", | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
J'ai décidé que ça ne vaut pas plus des contrôles sur le fichier (e.g. extension)
calummackervoy
removed
the
1-recette-jetable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Mettre en visibilité sur chaque groupe le nom, prénom et email du conseiller emploi France Travail
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
Sur l'importation des données
python manage.py import_advisor_information [import_file.xlsx] [--wet-run]Sur la visualisation des données
make populate_dbpublic_iddepuis le fichier admin de Jacques Henry (http://localhost:8000/admin/users/user/2/change/ - identifiant public)💻 Captures d'écran
Modifiable depuis le site admin (sous JobSeekerProfile)