Skip to content

UX/UI : Optimisation des images d'illustration au chargement #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

UX/UI : Optimisation des images d'illustration au chargement #4578

merged 1 commit into from
Aug 20, 2024

Conversation

@hellodeloo
Copy link
Contributor

@hellodeloo hellodeloo commented Aug 20, 2024 •
edited
Loading

🤔 Pourquoi ?

Optimiser le poids des pages au chargement

@hellodeloo hellodeloo self-assigned this Aug 20, 2024
@notion-workspace
Copy link

notion-workspace bot commented Aug 20, 2024

🏎️ UX/UI : Optimiser toutes les images aux chargement

@hellodeloo hellodeloo added the modifié Modifié dans le changelog. label Aug 20, 2024
@hellodeloo hellodeloo changed the title feat: add loading=lazy to illustration images UX/UI : Optimisation du chargement des images d'illustration Aug 20, 2024
@hellodeloo hellodeloo changed the title UX/UI : Optimisation du chargement des images d'illustration UX/UI : Optimisation des images d'illustration au chargement Aug 20, 2024
xavfernandez
xavfernandez approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A vérifier après le merge si cela permet de gagner quelques points sur https://pagespeed.web.dev/analysis/https-emplois-inclusion-beta-gouv-fr/fpq2yb69gu?form_factor=mobile (perf 82 sur mobile)

francoisfreitag
francoisfreitag approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En local, je gagne une centaine de ms sur l’évènement load 👍

@hellodeloo hellodeloo added this pull request to the merge queue Aug 20, 2024
Merged via the queue into master with commit e2a68be Aug 20, 2024
@hellodeloo hellodeloo deleted the deloo/add-loading-lazy-to-illustration-images branch August 20, 2024 14:07
@hellodeloo
Copy link
Contributor Author

hellodeloo commented Aug 20, 2024 •
edited
Loading

A vérifier après le merge si cela permet de gagner quelques points sur https://pagespeed.web.dev/analysis/https-emplois-inclusion-beta-gouv-fr/fpq2yb69gu?form_factor=mobile (perf 82 sur mobile)

Bon ben c'est moins bien !? (perf 69 sur mobile)
capture 2024-08-20 à 16 25 56

Je crois que celuil-là est en trop car toujours visible au dessus de la ligne de flottaison

@xavfernandez
Copy link
Contributor

xavfernandez commented Aug 20, 2024

Bon ben c'est moins bien !? (perf 69 sur mobile)

Pareil 😅

Je crois que celuil-là est en trop car toujours visible au dessus de la ligne de flottaison

👍 à enlever donc ?

@hellodeloo
Copy link
Contributor Author

hellodeloo commented Aug 20, 2024

👍 à enlever donc ?

Oui, tentative d'amélioration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@francoisfreitag francoisfreitag francoisfreitag approved these changes

Assignees

@hellodeloo hellodeloo

Labels

modifié Modifié dans le changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hellodeloo @xavfernandez @francoisfreitag