Performances: Utilisation de Brevo à la place de Mailjet pour la gestion de campagnes mails#4742
Merged
Conversation
tonial
force-pushed
the
alaurent/brevo
branch
from
97d6e90 to
bddbeb7
Compare
tonial
changed the title
tonial
force-pushed
the
alaurent/brevo
branch
3 times, most recently
from
f8a89c5 to
2b2117c
Compare
leo-naeka
reviewed
Sep 17, 2024
leo-naeka
left a comment
leo-naeka
left a comment
Contributor
There was a problem hiding this comment.
Mailjet ne devait pas avoir de SDK python, Brevo oui…
Je suis partagé entre garder un truc simple pour les seuls endpoints qu'on utilise de leur API et se reposer sur leur SDK, qui semble malgré tout bien testé.
tonial
force-pushed
the
alaurent/brevo
branch
3 times, most recently
from
ece0732 to
a012049
Compare
tonial
force-pushed
the
alaurent/brevo
branch
from
a012049 to
a3926ff
Compare
| users = ( | ||
| User.objects.filter(kind__in=[UserKind.PRESCRIBER, UserKind.EMPLOYER]) | ||
| .filter( | ||
| # Someday only filter on identity_provider ? |
Member
There was a problem hiding this comment.
Très bonne remarque, comme on force les nouveaux utilisateurs à utiliser un SSO, on peut prévoir de retirer le Exists(EmailAddress) juste après la première exécution de cette commande (qui permettra d’avoir tout de même les utilisateurs qui ne se sont pas connectés depuis 1 an, mais qui étaient dans Mailjet 😮💨). D’ici à ce qu’on migre à nouveau les campagnes de comm’, on pourra complètement oublier que les utilisateurs pro se sont un jour connectés via allauth.
tonial
force-pushed
the
alaurent/brevo
branch
3 times, most recently
from
6a374a7 to
d7e339f
Compare
tonial
force-pushed
the
alaurent/brevo
branch
3 times, most recently
from
a333aac to
4fa9d67
Compare
tonial
force-pushed
the
alaurent/brevo
branch
from
4fa9d67 to
b10c665
Compare
tonial
force-pushed
the
alaurent/brevo
branch
5 times, most recently
from
e97138e to
43cb04d
Compare
Member
|
Il faudra penser à mettre un monitor Sentry (cf https://itou.sentry.io/crons/les-emplois-prod/new-users-to-mailjet/?project=6164438&statsPeriod=7d) |
tonial
force-pushed
the
alaurent/brevo
branch
2 times, most recently
from
58558a2 to
7e8b2a8
Compare
tonial
commented
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran