Inscription : Parcours initialisation de mot de passe pour les candidats créés par un tiers [GEN-235]#4807
Merged
calummackervoy merged 2 commits intomasterfrom Oct 14, 2024
Conversation
calummackervoy
force-pushed
the
calum/notif-email-creation-jobseeker-third-party
branch
2 times, most recently
from
ff2d044 to
239161b
Compare
itou/templates/account/email/email_jobseeker_created_by_third_party_body.txt
Outdated
Show resolved
Hide resolved
itou/templates/account/email/email_jobseeker_created_by_third_party_body.txt
Outdated
Show resolved
Hide resolved
itou/templates/account/email/email_jobseeker_created_by_third_party_body.txt
Outdated
Show resolved
Hide resolved
calummackervoy
changed the title
calummackervoy
force-pushed
the
calum/notif-email-creation-jobseeker-third-party
branch
from
239161b to
b5c844d
Compare
calummackervoy
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
calummackervoy
force-pushed
the
calum/notif-email-creation-jobseeker-third-party
branch
4 times, most recently
from
12dc73b to
6440115
Compare
xavfernandez
approved these changes
Oct 11, 2024
Contributor
xavfernandez
left a comment
xavfernandez
left a comment
There was a problem hiding this comment.
Ça m'a l'air bon 👍
Le découpage des commits par contre me semble un peu bancal avec des corrections du premier commit dans le second donc le plus simple serait à mon avis de tous squasher.
feat(password reset): change reset page content if user has never logged in fix(snapshot): test class name changed feat(signup): new users are signed in during password initialization password_reset_from_key.html: improve content for invalid tokens fix(User.create_job_seeker_by_proxy): email content refactor(create_job_seeker_by_proxy): added JobSeekerCreatedByProxyNotification fix: token generation and test fix: create mdp content and explicit tests fix(test_password.py): flaky snapshot fix(jobseeker created by third party email content): changes requested fix(test_password.py): test should reset to a new password
calummackervoy
force-pushed
the
calum/notif-email-creation-jobseeker-third-party
branch
from
6440115 to
0e877df
Compare
Contributor
Author
|
@xavfernandez j'ai ajouté un commit après j'ai trouvé sur la recette qu'un utilisateur doit valider leur email après déconnexion - reconnexion: 47728e7 Je pense que ça suffit que l'utilisateur a créé son mdp avec le lien envoyé à son email pour le valider ? Le lien de création de mdp n'est pas réutilisable une fois que c'est utilisé |
Contributor
|
Ça me semble bien oui 👍 |
calummackervoy
deleted the
calum/notif-email-creation-jobseeker-third-party
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Quand un candidat est créé par un tier, on devrait lui notifier avec un lien qui lui permet définir son mot de passe
🚨 À vérifier
💻 Captures d'écran