Connexion : Empêcher les utilisateurs de remplacer leur SSO une fois ils sont inscrit [GEN-2115]#4828
Merged
calummackervoy merged 2 commits intomasterfrom Oct 2, 2024
Merged
Conversation
tonial
reviewed
Sep 27, 2024
calummackervoy
force-pushed
the
calum/bloquer-remplacement-de-sso
branch
2 times, most recently
from
bb6b5dd to
6e2f92b
Compare
calummackervoy
commented
Sep 30, 2024
tonial
reviewed
Sep 30, 2024
calummackervoy
force-pushed
the
calum/bloquer-remplacement-de-sso
branch
2 times, most recently
from
cfca4f7 to
90a0877
Compare
tonial
approved these changes
Sep 30, 2024
Contributor
tonial
left a comment
tonial
left a comment
There was a problem hiding this comment.
C'est presque bon :)
tu peux merger une fois InclusionConnectEmployerData corrigé
Je te laisse voir si tu veux modifier les noms de tests aussi
OIDConnectUserData: simplify method removing update_user_info
calummackervoy
force-pushed
the
calum/bloquer-remplacement-de-sso
branch
from
90a0877 to
19d435a
Compare
prevent candidates from replacing their django accounts as well refactor(openid_connect): one-liner private property drives property function refactor: tuples are immutable requested changes fix: quality
calummackervoy
force-pushed
the
calum/bloquer-remplacement-de-sso
branch
from
19d435a to
354c6f4
Compare
tonial
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Désormais quand l'utilisateur se connecte aux emplois avec un SSO (InclusionConnect, PEConnect, FranceConnect) et le compte n'existe pas mais le courriel est utilisé par un autre SSO, on va montrer en erreur. Précédemment on a laissé l'utilisateur à écraser son compte, et ça a causé des problèmes pour les utilisateurs qui partagent une adresse e-mail.
On permet toujours les utilisateurs à remplacer leur compte Django avec un compte SSO.
🍰 Comment ?
Sur un prochain ticket on va remplacer les alertes / modales affichées avec des alertes qui rédirigent vers le connexion. Je les ai laissé dans l'état actuel pour l'instant pour simiplifier cette étape ci.
Extension de #4810
🚨 À vérifier