Skip to content

Candidature: Amélioration de la validation du NIR#4882

Merged
tonial merged 1 commit intomasterfrom
alaurent/nir_validation
Oct 8, 2024
Merged

Candidature: Amélioration de la validation du NIR#4882
tonial merged 1 commit intomasterfrom
alaurent/nir_validation

Conversation

@tonial
Copy link
Contributor

@tonial tonial commented Oct 7, 2024

🤔 Pourquoi ?

Quand le mois 'est pas une valeur entre 1 et 12, on ne peut pas comparer avec le mois de naissance renseigné.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial added the modifié Modifié dans le changelog. label Oct 7, 2024
@tonial tonial requested a review from francoisfreitag October 7, 2024 09:43
@tonial tonial self-assigned this Oct 7, 2024
@tonial tonial force-pushed the alaurent/nir_validation branch from 7aa6f32 to e206884 Compare October 7, 2024 09:44
@tonial tonial force-pushed the alaurent/nir_validation branch from e206884 to b1bc86d Compare October 7, 2024 12:46
@tonial tonial requested a review from francoisfreitag October 7, 2024 12:46
@tonial tonial force-pushed the alaurent/nir_validation branch from b1bc86d to 7e7cd3c Compare October 8, 2024 10:01
response = self.client.post(url, data=post_data)

assert response.status_code == 200
self.assertContains(response, JobSeekerProfile.ERROR_JOBSEEKER_INCONSISTENT_NIR_BIRTHDATE % "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.assertContains(response, JobSeekerProfile.ERROR_JOBSEEKER_INCONSISTENT_NIR_BIRTHDATE % "")
self.assertContains(response, JobSeekerProfile.ERROR_JOBSEEKER_INCONSISTENT_NIR_BIRTHDATE)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est nécessaire parce qu'il y a un %s dans JobSeekerProfile.ERROR_JOBSEEKER_INCONSISTENT_NIR_BIRTHDATE

@tonial tonial force-pushed the alaurent/nir_validation branch from 7e7cd3c to 140e337 Compare October 8, 2024 13:39
@tonial tonial force-pushed the alaurent/nir_validation branch from 140e337 to 527e31e Compare October 8, 2024 13:42
@tonial tonial marked this pull request as ready for review October 8, 2024 13:43
@tonial tonial enabled auto-merge October 8, 2024 13:43
@tonial tonial added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit d41eeb7 Oct 8, 2024
@tonial tonial deleted the alaurent/nir_validation branch October 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modifié Modifié dans le changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants