admin: amélioration de la recherche de PASS IAE#4905
Merged
xavfernandez merged 1 commit intomasterfrom Oct 15, 2024
Merged
Conversation
francoisfreitag
approved these changes
Oct 9, 2024
xavfernandez
force-pushed
the
xfernandez/improve_approval_search
branch
from
67ac0c5 to
0506adc
Compare
francoisfreitag
approved these changes
Oct 10, 2024
xavfernandez
force-pushed
the
xfernandez/improve_approval_search
branch
from
0506adc to
0647b5b
Compare
rsebille
approved these changes
Oct 10, 2024
Contributor
rsebille
left a comment
rsebille
left a comment
There was a problem hiding this comment.
A voir sur la durée mais je pense qu'on essaye de faire trop malin en gérant tout les sous-cas pour le NIR et qu'on se retrouver avec des comportements moins prévisibles pour ;).
xavfernandez
force-pushed
the
xfernandez/improve_approval_search
branch
3 times, most recently
from
c69433c to
694d734
Compare
Contributor
Author
Yup, je me demandais pareil donc j'ai encore une nouvelle fois changé 🙈 |
Locally when searching by approval number, it goes from 5 sec to 30 ms
xavfernandez
force-pushed
the
xfernandez/improve_approval_search
branch
from
694d734 to
152810c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Localement, la recherche d'un PASS par numéro passe de 5 secondes à 30 ms.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran