Connexion: Amélioration de la fiabilité de la connexion avec ProConnect#5097
Merged
Conversation
francoisfreitag
approved these changes
Nov 15, 2024
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Pour être plus réalistes, on pourrait ajouter iat aux OIDC_USERINFO de pro connect.
| key=constants.PRO_CONNECT_CLIENT_SECRET, | ||
| algorithms=["HS256"], | ||
| audience=constants.PRO_CONNECT_CLIENT_ID, | ||
| options={"verify_iat": False}, |
Member
There was a problem hiding this comment.
Peut-être mettre en commentaire l’issue, avec un TODO, pour qu’on retire ce comportement une fois que c’est le défaut ?
A difference between or serveur clocks causes some ImmatureSignatureError. It' not even mandatory to check it, see jpadilla/pyjwt#939
tonial
force-pushed
the
alaurent/proconnect_iat
branch
from
d7eeb98 to
452f927
Compare
Contributor
Author
|
J'ai ajouté l'iat au user_info justement, en le mettant une heure après timezone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
La vérification du token user_info plante parfois à cause d'un décalage de l'horloge de nos serveurs qui cause un ImmatureSignatureError.
La vérification de ce champs n'est pas obligatoire, on la retire donc (voir jpadilla/pyjwt#939)
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran