PASS IAE: correction de la vue de détail pour d'anciens PASS liés à des candidatures acceptées sans date de début d'embauche #5116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to handle the (common) case of old accepted job applications lacking a hiring_start_at.
xavfernandez
force-pushed
the
xfernandez/fix_approval_details
branch
from
092c7be to
9d72c5e
Compare
rsebille
approved these changes
Nov 19, 2024
| last_hiring = approval.jobapplication_set.accepted().order_by("hiring_start_at").last() | ||
| if last_hiring is None or any( | ||
| suspension.end_at > last_hiring.hiring_start_at for suspension in long_suspensions | ||
| last_hiring_start_at = approval.jobapplication_set.accepted().aggregate(Max("hiring_start_at"))[ |
Contributor
There was a problem hiding this comment.
Pas plus simple de faire ça ?
Suggested change
| last_hiring_start_at = approval.jobapplication_set.accepted().aggregate(Max("hiring_start_at"))[ | |
| last_hiring = approval.jobapplication_set.accepted().latest("hiring_start_at") |
Contributor
Author
There was a problem hiding this comment.
Il faudrait aussi rajouter un .exclude(hiring_start_at=None).
Cf la note de https://docs.djangoproject.com/en/5.1/ref/models/querysets/#django.db.models.query.QuerySet.latest earliest() and latest() may return instances with null dates.
Et je me dis que c'est plus joli de ne demander que la date plutôt que de récupérer toutes les infos de la candidature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Sinon, ça 💥 avec
'>' not supported between instances of 'datetime.date' and 'NoneType'Cf https://itou.sentry.io/issues/6011765619/?project=6164438 & https://itou-inclusion.slack.com/archives/C01181Y04LT/p1731954611260899 &
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran