Corriger le message d’erreur de validate_birth_location [GEN-2265]#5173
Merged
Conversation
francoisfreitag
force-pushed
the
ff/pays-validation
branch
2 times, most recently
from
7fd2d5b to
b81457d
Compare
francoisfreitag
changed the title
francoisfreitag
added
1-recette-jetable
xavfernandez
approved these changes
Nov 29, 2024
Contributor
xavfernandez
left a comment
xavfernandez
left a comment
There was a problem hiding this comment.
Top les nouveaux tests sur tous les parcours 👍
francoisfreitag
force-pushed
the
ff/pays-validation
branch
from
b81457d to
e3b89ef
Compare
francoisfreitag
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
francoisfreitag
removed
the
1-recette-jetable
The error messages were swapped wrt their conditions. Refactor the validator to be clearer by cascading ifs. Add missing tests to all classes using the mixin.
francoisfreitag
force-pushed
the
ff/pays-validation
branch
from
e3b89ef to
777041f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Les messages d’erreurs disaient l’inverse des
ifqui les gardaient.🏝️ Comment tester