Retirer l’affichage du NIR pour les orienteurs qui n’ont pas créé le compte du candidat [GEN-2254]#5234
Merged
Merged
Conversation
dejafait
marked this pull request as draft
December 9, 2024 14:13
dejafait
force-pushed
the
dejafait/hide_nir
branch
from
December 9, 2024 14:27
3310d86 to
da3a6c3
Compare
dejafait
force-pushed
the
dejafait/hide_nir
branch
from
December 9, 2024 14:31
da3a6c3 to
2534aad
Compare
dejafait
marked this pull request as ready for review
December 9, 2024 14:41
| {% if job_seeker.jobseeker_profile.nir %} | ||
| <strong>{{ job_seeker.jobseeker_profile.nir|format_nir }}</strong> | ||
| {% include 'includes/copy_to_clipboard.html' with content=job_seeker.jobseeker_profile.nir css_classes="btn-link" only_icon=True %} | ||
| <strong>{{ job_seeker.jobseeker_profile.nir|mask_unless:can_view_personal_information|format_nir }}</strong> |
Contributor
There was a problem hiding this comment.
A voir avec le métier mais pourquoi ne pas cacher toute la section, comme on le fait déjà pour le téléphone, l'adresse email, la date de naissance, l'adresse et l'identifiant France Travail ?
Contributor
Author
There was a problem hiding this comment.
Ah bah oui, c'est tout à fait logique ! Je n'avais pas regardé le gabarit avec assez de recul. Je fais ça.
Contributor
Author
There was a problem hiding this comment.
C'est fait. Nouveau screenshot "après" :
Ok pour toi ? @xavfernandez
added 2 commits
December 12, 2024 15:37
xavfernandez
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Le lien automatique Notion/Github ne semble pas fonctionner aujourd’hui du coup voici le lien du ticket : https://www.notion.so/plateforme-inclusion/Retirer-l-affichage-du-NIR-pour-les-orienteurs-qui-n-ont-pas-cr-le-compte-du-candidat-143e8fa5c35b80be9e73d9981f9851ba
🤔 Pourquoi ?
A partir du moment où on masque le nom prénom on doit aussi masquer le NIR.
🍰 Comment ?
On masque tous les chiffres du NIR sauf le premier, pour rester en harmonie avec le masque existant du nom prénom. Le premier chiffre du NIR révèle le genre de la personne mais je suppose qu'on peut vivre avec ça.
💻 Captures d'écran
Avant :
Après :