Demandeur d’emploi : Suppression du champ de l'aide ATA - #5312
Merged
Conversation
xavfernandez
approved these changes
Jan 6, 2025
xavfernandez
left a comment
Contributor
There was a problem hiding this comment.
Moi je suis toujours plutôt pour que les mises en prod se fassent sans coupure (:handshake: SeparateDatabaseAndState) 🤷♂️
Mais si tu préfères merger quand il n'y a personne ça me va aussi.
rsebille
force-pushed
the
rsebille/jobseeker-remove-ata-fields
branch
from
January 6, 2025 09:39
d060632 to
0e685b5
Compare
This field is not displayed nor filled since a7fb1cb.
rsebille
force-pushed
the
rsebille/jobseeker-remove-ata-fields
branch
from
January 6, 2025 09:49
0e685b5 to
0d07c53
Compare
rsebille
added this pull request to the merge queue
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Ce champ n'a jamais été utilisé, le champ dans le formulaire a été enlevé avant la mise en prod : a7fb1cb
🍰 Comment ?
Je fait un
RemoveField()"bourrin" car un peu (beaucoup) la flemme de faire une danceSeparateDatabaseAndState()mais vu qu'on touche auJobSeekerProfile()ça serais peut-être mieux que de passer la PR hors heures d'affluences.