Notifications: Correction de l'envoi de certaines notifications#5343
Merged
Conversation
tonial
force-pushed
the
alaurent/notifications_various_fixes
branch
2 times, most recently
from
a162235 to
2b804fc
Compare
tonial
force-pushed
the
alaurent/notifications_various_fixes
branch
from
2b804fc to
4ab98cb
Compare
Comment on lines
+25
to
+26
| if not self.user.is_active: | ||
| return |
Contributor
There was a problem hiding this comment.
Il ne faudrait pas le mettre après le gros if vérifiant les memberships pour forward aux admins ?
tonial
force-pushed
the
alaurent/notifications_various_fixes
branch
from
4ab98cb to
6b65553
Compare
tonial
force-pushed
the
alaurent/notifications_various_fixes
branch
from
6b65553 to
daa58e3
Compare
| for admin in admins: | ||
| self.__class__(admin, self.structure, self.user, **self.context).send() | ||
| if not self.user.is_active: | ||
| return |
Contributor
There was a problem hiding this comment.
Est-ce que cela n'aurait pas plus de sens d'être intégré au should_send ?
The sender may be an employer
tonial
force-pushed
the
alaurent/notifications_various_fixes
branch
from
daa58e3 to
d53b340
Compare
xavfernandez
approved these changes
Jan 14, 2025
| # name: test_employer_create_update_notification_settings[view queries - disable all notifications] | ||
| dict({ | ||
| 'num_queries': 19, | ||
| 'num_queries': 22, |
Contributor
There was a problem hiding this comment.
Ça me chagrine un peu toutes ces requêtes mais ça sera pour une autre fois 🙈
Contributor
Author
There was a problem hiding this comment.
J'ai eu la même reaction. Mais vu que c'est pas une page très utilisée, je me suis dit que c'était pas super grave
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Certaines notifications ne prennent pas en compte la configuration par l'utilisateur, ou alors peuvent être envoyée à un utilisateur désactivé
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran