Inscription : Ajouter les champs lieu et pays de naissance pour les candidats [GEN-1946]#5351
Merged
Merged
Conversation
francoisfreitag
requested review from
EwenKorr,
calummackervoy,
celine-m-s and
xavfernandez
January 7, 2025 12:50
francoisfreitag
added
the
1-recette-jetable
Member
Author
|
Vous êtes nombreux à être intéressés par le sujet, alors je vous invite tous à la relecture 🤗 |
francoisfreitag
changed the title
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
francoisfreitag
changed the title
celine-m-s
approved these changes
Jan 7, 2025
tonial
reviewed
Jan 8, 2025
tonial
approved these changes
Jan 8, 2025
EwenKorr
approved these changes
Jan 8, 2025
calummackervoy
approved these changes
Jan 8, 2025
calummackervoy
left a comment
calummackervoy
left a comment
Contributor
There was a problem hiding this comment.
Avec ce PR je peux améliorer la redirection lors de l'enregistrement des utilisateurs en double (champs de naissance correspondants)
francoisfreitag
force-pushed
the
ff/job-seeker-info-fields
branch
3 times, most recently
from
January 9, 2025 10:39
12bc2ba to
4be772f
Compare
Make sure users are able to complete their profile in order to have their IAE eligibility certified. The BirthPlaceAndCountryMixin base class changed from ModelForm to Form to allow the job seeker sign up process to reuse it. The `_post_clean()` hook isn’t available on regular Forms, the validation didn’t need that hook and was merged with `clean()`.
Users in the process of completing the tunnel won’t have the keys in their session.
francoisfreitag
force-pushed
the
ff/job-seeker-info-fields
branch
from
January 9, 2025 10:41
28597be to
55431cb
Compare
xavfernandez
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Afin de certifier l’éligibilité d’un candidat à certains critères administratifs et lui octroyer automatiquement les droits à un parcours IAE, l’API particulier requiert la commune et le pays de naissance. Ces informations sont maintenant requises pour l’inscription sur les Emplois de l’inclusion.
🍰 Comment ?
La classe de base
BirthPlaceAndCountryMixinhérite désormais deForm, non plus deModelForm. Ceci permet au formulaire d’inscription (qui n’est pas unModelForm) de réutiliser le mixin. Le point d’extension_post_clean()n’est pas disponible sur lesForm, sa logique a été intégrée dans la méthodeclean().🏝️ Comment tester
💻 Captures d'écran