Le badge 20+ candidatures sur les résultats de recherche ne doit pas inclure de candidatures archivées#5378
Merged
Merged
Conversation
dejafait
force-pushed
the
dejafait/fix_annotation_is_popular
branch
from
ead2a31 to
5538caa
Compare
dejafait
changed the title
tonial
reviewed
Jan 14, 2025
Contributor
|
C'est beaucoup plus logique avec ton renommage :) |
leo-naeka
reviewed
Jan 20, 2025
leo-naeka
left a comment
leo-naeka
left a comment
Contributor
There was a problem hiding this comment.
Mêmes remarques qu'Antoine, à part cela tout bon 👌
dejafait
force-pushed
the
dejafait/fix_annotation_is_popular
branch
from
5538caa to
278ab51
Compare
leo-naeka
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/plateforme-inclusion/Le-badge-20-candidature-sur-les-r-sultats-de-recherche-ne-doit-pas-inclure-de-candidatures-archiv-e-177e8fa5c35b80e49344f093e58cf484
🤔 Pourquoi ?
Les candidatures archivées (trop anciennes) ne doivent pas être comptées pour l’affichage du badge 20+ candidatures car :
🌈 Et un petit bonus technique en passant
popularenoverwhelmedqui est plus pertinent car l'état en question est en fait indésirable.