Conversation
Contributor
xavfernandez
left a comment
xavfernandez
left a comment
There was a problem hiding this comment.
Est-ce que ces lookup_allowed ne viennent pas en doublon de follow_up_groups_or_members ?
Si on veut les infos, cela semble plus simple d'aller sur la fiche de l'utilisateur ?
Contributor
Author
|
Le allow_lookup c'est pour éviter une 404 : |
tonial
force-pushed
the
alaurent/gps_admin
branch
2 times, most recently
from
10bd518 to
1274c39
Compare
xavfernandez
approved these changes
Jan 14, 2025
Contributor
xavfernandez
left a comment
xavfernandez
left a comment
There was a problem hiding this comment.
Ah oui effectivement, tu ne fais qu'un lien vers la vue liste, je pensais avoir vu un Inline.
Ça mériterait peut-être des petits tests ?
Contributor
Author
|
Je me suis dit que vu que c'était une feature pour GPS c'était pas grave 🙈 |
tonial
force-pushed
the
alaurent/gps_admin
branch
from
1274c39 to
a02014d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
https://www.notion.so/gip-inclusion/Faire-figurer-les-groupes-de-suivi-sur-les-pages-utilisateurs-de-l-admin-1735f321b6048037828cdf72eb037f24?pvs=4
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran