UX/UI: Changer de input type pour les numéros de téléphone#5388
Merged
Conversation
hellodeloo
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
francoisfreitag
approved these changes
Jan 14, 2025
francoisfreitag
left a comment
francoisfreitag
left a comment
Member
There was a problem hiding this comment.
Autrement ça m’a l’air bien.
| widgets = { | ||
| "description": EasyMDEEditor, | ||
| } | ||
| widgets = {"description": EasyMDEEditor, "phone": forms.TextInput(attrs={"type": "tel"})} |
Member
There was a problem hiding this comment.
L’ajout de la virgule dira au formatteur de laisser sur plusieurs lignes, ce qui est plus lisible.
Suggested change
| widgets = {"description": EasyMDEEditor, "phone": forms.TextInput(attrs={"type": "tel"})} | |
| widgets = {"description": EasyMDEEditor, "phone": forms.TextInput(attrs={"type": "tel"}),} |
Contributor
Author
There was a problem hiding this comment.
Trop bien, ça m'énervait et je ne comprenais pas pourquoi il ne voulait pas passer les éléments à la ligne
hellodeloo
force-pushed
the
deloo/fix-input-type-text-to-tel
branch
from
dace273 to
2d13b09
Compare
xavfernandez
approved these changes
Jan 15, 2025
hellodeloo
force-pushed
the
deloo/fix-input-type-text-to-tel
branch
from
2d13b09 to
fda8f5e
Compare
xavfernandez
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
https://www.notion.so/plateforme-inclusion/Changer-le-type-du-champ-T-l-phone-et-ajouter-un-pattern-15fe8fa5c35b8062b855e676197729dc?pvs=4
Pour permettre aux navigateurs mobiles d'ouvrir un clavier optimisé pour la saisie d'un numéro de tel
🍰 Comment ?
Passer le champ en inpup type=text des numéros de téléphone, en type=tel sans pattern