[IDOR] Admin: sécurisation des urls de gestion des membres [GEN-2399]#5417
Merged
Conversation
vincentporte
added
modifié
vincentporte
changed the title
vincentporte
commented
Jan 20, 2025
vincentporte
force-pushed
the
vp/idor_deactivate_member
branch
2 times, most recently
from
b9e3ed8 to
82eb809
Compare
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Pour moi, il n’y a pas IDOR ici non plus, car les membres sont limités aux membres de l’entreprise et l’accès est vérifié par des contrôles (est bien admin de la structure, etc).
On peut accéder à la liste des membres de la structure par une page dédiée, et on affichera 404 si on essai d’utiliser un chemin avec une PK (ou un public id) d’un utilisateur non membre de la structure.
vincentporte
force-pushed
the
vp/idor_deactivate_member
branch
2 times, most recently
from
2565d7d to
ac8fded
Compare
vincentporte
force-pushed
the
vp/idor_deactivate_member
branch
from
ac8fded to
30faa05
Compare
xavfernandez
approved these changes
Mar 4, 2025
| # To be removed when the old URL is no longer used | ||
| @check_user(lambda user: user.is_employer) | ||
| def update_admin_role(request, action, user_id, template_name="companies/update_admins.html"): | ||
| def deactivate_member_temp_redirection(request, user_id): |
Contributor
There was a problem hiding this comment.
On pourrait n'avoir qu'une seule vue:
def deactivate_member(request, public_id=None, user_id=None, template_name="companies/deactivate_member.html"):
et gérer en fonction de l'argument présent.
Contributor
|
Et j'aurais plutôt vu 3 commits différents pour |
vincentporte
force-pushed
the
vp/idor_deactivate_member
branch
from
30faa05 to
49c4d01
Compare
vincentporte
changed the title
added 3 commits
March 5, 2025 17:53
vincentporte
force-pushed
the
vp/idor_deactivate_member
branch
from
49c4d01 to
d60557f
Compare
vincentporte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Catégories changelog
Employeur, Prescripteur, Institutions
🍰 Comment ?
🦺 remplacer les
idpar lespublic_id🦺 ajout de 3 routes temporaires pour le deploiement
zero downtime🦺 simplification de routes utilisant
re_path, pour supprimer lesregexsur lesuuid🚨 À vérifier
ref notion