Candidature: conserver le mode d'affichage (Tableau/Liste) quand on efface tous les filtres#5435
Merged
Merged
Conversation
tonial
approved these changes
Jan 23, 2025
tonial
left a comment
tonial
left a comment
Contributor
There was a problem hiding this comment.
Tu pourrais vérifier que le lien de reset contient ce query param ?
When removing all filter from table view, users expect to stay in table view.
xavfernandez
force-pushed
the
xfernandez/fix_reset_filter_button
branch
from
e83ace4 to
cd4a256
Compare
Contributor
Author
|
J'ai snapshoté :) |
| <div class="ms-md-auto" id="apply-list-filter-counter"{% if request.htmx %} hx-swap-oob="true"{% endif %}> | ||
| {% if filters_counter > 0 %} | ||
| <a href="{{ reset_url }}" class="btn btn-ico btn-dropdown-filter" aria-label="Réinitialiser {{ filters_counter|pluralizefr:"le filtre actif,les filtres actifs" }}"> | ||
| <a href="{{ reset_url }}?display={{ display_kind }}" class="btn btn-ico btn-dropdown-filter" aria-label="Réinitialiser {{ filters_counter|pluralizefr:"le filtre actif,les filtres actifs" }}"> |
Member
There was a problem hiding this comment.
Pourquoi ne pas avoir utilisé un URL dédié ?
Contributor
Author
There was a problem hiding this comment.
Avec un {% url_add_query list_url display=display_kind as reset_url %} ?
Member
There was a problem hiding this comment.
Non, je pensais changer directement le path plutôt qu’un query param. Ça permet de retenir la vue en cours sans tricher.
Contributor
Author
There was a problem hiding this comment.
Ah oui, mais c'est plus impactant cela 😅 .
Avec la vue tableau qui va passer par défaut (et du coup la vue liste qui serait en sursis ?), je ne vais pas me précipiter 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Actuellement, quand on se met en mode tableau et qu'on ajoute des filtres (ou dans l'autre sens), si on enlève ensuite les filtres avec le bouton "Effacer tout", on est rebasculé en mode liste.
Pas trop d'idée de test par contre...
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran