Connexion: Suppression du code de connexion via Inclusion Connect #5443
Merged
Conversation
tonial
force-pushed
the
alaurent/rip_ic
branch
4 times, most recently
from
bf6abec to
a5cab1c
Compare
tonial
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
tonial
force-pushed
the
alaurent/rip_ic
branch
5 times, most recently
from
eb071fb to
235f925
Compare
tonial
requested review from
calummackervoy,
francoisfreitag and
xavfernandez
tonial
force-pushed
the
alaurent/rip_ic
branch
3 times, most recently
from
aac23f1 to
f25718c
Compare
tonial
force-pushed
the
alaurent/rip_ic
branch
from
f25718c to
cdf6ed7
Compare
Contributor
calummackervoy
left a comment
calummackervoy
left a comment
There was a problem hiding this comment.
Bravo, toujours content d'avoir 2500 lignes de code de moins 🧹
Comment on lines
360
to
+361
| class AccountMigrationView(TemplateView): | ||
| template_name = "account/activate_inclusion_connect_account.html" | ||
| template_name = "account/activate_pro_connect_account.html" |
Contributor
There was a problem hiding this comment.
OK :)
Je vois qu'on a middleware qui rédirige les utilisateurs d'InclusionConnect à cette vue. Quand ils tape sur le bouton ProConnect ils doivent s'inscrire / se connecter ailleurs, et quand ils revient on va modifier le SSO de leur compte.
Ça vaut un test qui cible ce processus en particulier, IC -> PC ?
Contributor
Author
There was a problem hiding this comment.
Les utilisateurs d'inclusion_connect ne sont plus redirigés (car ils ne peuvent plus se connecter avec cette PR)
Un utilisateur utilisant IC par le passé et se connectant avec ProConnect sera migré (cf test_get_existing_user_with_same_email_IC).
tonial
force-pushed
the
alaurent/rip_ic
branch
from
cdf6ed7 to
8d07721
Compare
tonial
force-pushed
the
alaurent/rip_ic
branch
from
8d07721 to
32e0204
Compare
tonial
force-pushed
the
alaurent/rip_ic
branch
from
32e0204 to
d06c947
Compare
tonial
force-pushed
the
alaurent/rip_ic
branch
from
d06c947 to
2bb68f3
Compare
tonial
force-pushed
the
alaurent/rip_ic
branch
from
2bb68f3 to
f74c1fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Inclusion Connect va bientôt disparaître 😢
Sur les environnements de démo/recette/dev où ProConnect n'est pas disponible : on améliore le message pour dire d'utiliser les compte de démonstration.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran