Admin: Correction du formulaire des diagnostics d'éligibilité.#5485
Merged
Admin: Correction du formulaire des diagnostics d'éligibilité.#5485
Conversation
xavfernandez
approved these changes
Jan 28, 2025
Contributor
xavfernandez
left a comment
xavfernandez
left a comment
There was a problem hiding this comment.
Je me dis qu'on pourrait toujours rajouter un messages.warning quand on affecte une organisation prescriptrice non habilitée (sans bloquer).
tonial
force-pushed
the
alaurent/admin_diags
branch
from
d39c05a to
0a8cc76
Compare
When fixing past diagnosis, the organization may not be authorized anymore
tonial
force-pushed
the
alaurent/admin_diags
branch
from
0a8cc76 to
faaee4d
Compare
| # Allow inactive membership as we may want to fix old diagnoses | ||
| self.add_error("author_prescriber_organization", "L'auteur n'appartient pas à cette organisation.") | ||
| if author_prescriber_organization and not author_prescriber_organization.is_authorized: | ||
| logger.warning("L'organization prescriptrice n'est actuellement pas habilité.") |
Contributor
There was a problem hiding this comment.
Je m'attendais à un messages.warning(request, ...): l'idée c'est que l'utilisateur voit le message 😅
Contributor
Author
There was a problem hiding this comment.
Je crois que les 2 nuits catastrophiques de suite n'aident pas mon cerveau....
Contributor
Author
There was a problem hiding this comment.
Et j'ai oublié de bloquer retirer de la merge queue 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Une organisation prescriptrice peut ne plus être habilitée au moment ou l'on modifie le diagnostic pour régulation.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran